Hallvord R. M. Steen [:hallvors] Reporter
	Description • 11 years ago

Test cases that do not throw the expected exception:
http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/open-url-multi-window-2.htm
http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/open-url-multi-window-3.htm
http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/open-url-multi-window-5.htm

	Thomas Wisniewski Assignee
	Comment 1 • 8 years ago

Two of those tests are now passing, and this patch fixes the last one: http://w3c-test.org/XMLHttpRequest/open-url-multi-window-3.htm

I'm doing a try run now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3ebd554b6f5

	Thomas Wisniewski Assignee
	Comment 2 • 8 years ago

Comment on attachment 8770411 [details] [diff] [review]
918734-throw_invalid_state_errors_on_CheckInnerWindowCorrectness_XHR_failures_to_match_the_spec.diff

The try run in comment 1 passed, so I'm requesting review.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 3 • 8 years ago

Comment on attachment 8770411 [details] [diff] [review]
918734-throw_invalid_state_errors_on_CheckInnerWindowCorrectness_XHR_failures_to_match_the_spec.diff

Review of attachment 8770411 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xhr/XMLHttpRequestMainThread.cpp
@@ +1443,5 @@
>        return NS_ERROR_DOM_SYNTAX_ERR;
>      }
>      return rv;
>    }
> +  if (NS_WARN_IF(NS_FAILED(CheckInnerWindowCorrectness()))) {

nit: add a \n above the if

	Thomas Wisniewski Assignee
	Comment 4 • 8 years ago

Nit addressed, carrying over r+. Thanks for the review!

	Pulsebot
	Comment 5 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6afd23d2579f
Throw invalid state errors when XHRs fail their CheckInnerWindowCorrectness() checks, to match the XHR spec. r=khuey

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6afd23d2579f