dude. that's pretty legendary! I'll rubberstamp this assuming it compiled :). make sure you got an android compile in as you touched some android specific ifdefs in tickler. does it move the needle on build times? thanks!

(In reply to Patrick McManus [:mcmanus] from comment #1) > dude. that's pretty legendary! > > I'll rubberstamp this assuming it compiled :). make sure you got an android > compile in as you touched some android specific ifdefs in tickler. Yeah, I usually submit a first draft for review and make it actually build on all platforms on try and don't bother asking for a new review on the final version. (And yes, the tickler changes did not build on Android on this patch like you guessed!) > does it move the needle on build times? I have stopped measuring this for individual patches. The changes individually contribute to lower build times, *especially* since fewer files will need to be rebuilt in incremental builds, but they do have positive impacts on clobber build times, and the Windows PGO linker memory usage as well. Follow bug 785103 if you're interested in the gradual work we're doing on this.