Closed
Bug 9191
Opened 25 years ago
Closed 23 years ago
Default value of border-collapse incorrect
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
INVALID
Future
People
(Reporter: dbaron, Assigned: ian)
References
Details
(Keywords: css2, Whiteboard: [nsbeta3-])
Attachments
(2 files)
Tested on: mozilla.org 1999-06-30-08-M8, Linux.
Test case to be attached.
The default value of the border-collapse property, per CSS2, is collapse. This
is not happening. It would be acceptable (although not advisable, I think) for
ua.css to set border-collapse: separate on table. However, that is not what is
happening.
The test case to be attached shows that the separated borders model is being
used for both table and <div style="display: table"> (using classes...). If the
separated borders model were used, the first two tables would look the same as
the last two.
I think the border and frame attributes of table (only some values of frame)
should set border-collapse to separate. It shouldn't be that by default.
I highly recommend that you wait until bug 9024 is fixed before fixing this bug,
since border-collapse:collapse on empty tables can lead to instability (there
are a bunch of asserts on empty tables with border-collapse:collapse, I think).
The display glitch in the bottom row of the test case may be related to bug
2886, but may be separate. Someone (I?) should investigate further and file
another bug if needed...
Reporter | ||
Comment 1•25 years ago
|
||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M9
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Reporter | ||
Comment 2•25 years ago
|
||
I'm reopening this because I believe (from the newsgroups) that the fix was
backed out to fix bug 11441. As I said before, I think this should wait until
bug 9024 (and any other collapsing border crashes) are fixed.
I think when you fix this, you should change the style mapping code for the
border attribute and some/all values of the frame attribute to set border-
separate: separate, and leave the HTML default as collapse.
Resolution: FIXED → ---
Updated•25 years ago
|
Target Milestone: M9 → M10
Comment 3•25 years ago
|
||
Deferring to M10
Updated•25 years ago
|
Target Milestone: M10 → M15
Comment 4•25 years ago
|
||
Moving non-beta 1 items to M15
Assignee | ||
Updated•25 years ago
|
Summary: Default value of border-collapse incorrect → {css2} Default value of border-collapse incorrect
Updated•25 years ago
|
Assignee: peterl → pierre
Status: REOPENED → NEW
Comment 5•25 years ago
|
||
Reassigning peterl's bugs to myself.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 6•25 years ago
|
||
Accepting peterl's bugs that have a Target Milestone
Updated•25 years ago
|
Target Milestone: M15 → M16
Comment 7•25 years ago
|
||
Pushing my M15 bugs to M16
Updated•25 years ago
|
Target Milestone: M16 → M15
Comment 8•25 years ago
|
||
Moving table bugs to M15 just to see how many we have.
Assignee | ||
Comment 9•25 years ago
|
||
Migrating from {css2} to css2 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...
Updated•25 years ago
|
Summary: {css2} Default value of border-collapse incorrect → Default value of border-collapse incorrect
Comment 10•25 years ago
|
||
Block-moved to attinasi the bugs related to style inside tables
Assignee: pierre → attinasi
Status: ASSIGNED → NEW
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•25 years ago
|
OS: Linux → All
Hardware: PC → All
Comment 11•25 years ago
|
||
> It would be acceptable (although not advisable, I think) for
> ua.css to set border-collapse: separate on table.
Necessary in fact, because of the way that HTML tables work - cellspacing, etc.
Reporter | ||
Comment 12•25 years ago
|
||
No, the alternative is to set it in the attribute mapping code, but only do so
for some border styles.
Reporter | ||
Comment 13•25 years ago
|
||
Er... values of the rules or frame attributes, not border styles.
Comment 14•25 years ago
|
||
Karnaze needs to fix the table code to deal with collapsed borders better before
we can change the default to collapse. Once we can change the default in
html.css to 'border-collapse:collapse' (or better yet, just remove the rule)
then we will look at this further to see what the story is with the DIV that has
a display:table rule. Moving to M16 to match the dependent bug.
Depends on: 22897
Target Milestone: M15 → M16
Comment 15•25 years ago
|
||
Moving to M17 to match dependent bug 22897
(I cannot change the default until collapsed borders work correctly).
Target Milestone: M16 → M17
Updated•24 years ago
|
Target Milestone: M17 → M18
Updated•24 years ago
|
Keywords: correctness
Updated•24 years ago
|
Priority: P3 → P2
Comment 18•24 years ago
|
||
Since bug 41262 was nsbeta3-'d, this bug is getting nsbeta3-'d too. Will change
the default when collapsing borders work correctly.
Whiteboard: [nsbeta3+] → [nsbeta3-]
Target Milestone: M18 → Future
Assignee | ||
Comment 19•24 years ago
|
||
Netscape's standard compliance QA team reorganised itself once again, so taking
remaining non-tables style bugs. Sorry about the spam. I tried to get this done
directly at the database level, but apparently that is "not easy because of the
shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
Assignee | ||
Comment 20•24 years ago
|
||
there is a proposal in the CSS WG to make this bug INVALID by changing the
initial value in the spec...
Assignee | ||
Updated•24 years ago
|
QA Contact: ian → amar
Comment 22•23 years ago
|
||
Was just working with border-collapse, noticed that it's fixed.
Comment 23•23 years ago
|
||
Reassigned to Ian to do some follow-up with the WG and maybe fix it when a
decision is taken.
The places where the property is initialized are:
http://lxr.mozilla.org/seamonkey/source/content/shared/src/nsStyleStruct.cpp#743
http://lxr.mozilla.org/seamonkey/source/layout/mathml/content/src/mathml.css#148
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#136
Assignee: pierre → ian
Comment 24•23 years ago
|
||
don't know if i'm 100% on topic here but i got some comments on border-collapse,
too. i don't get mozilla (2001 101117 win2k) to display the
border-collapse:collapse as expected.
the w3c spec is at:
http://www.w3.org/TR/REC-CSS2/tables.html#propdef-border-collapse
also see the testcase png i submitted, comparing mozilla <--> w3c
border-collapse rendering.
phil.
Comment 25•23 years ago
|
||
border-collapse has been disabled for a long time and is planned to be back in
m0.9.7.
Comment 26•23 years ago
|
||
Comment 27•23 years ago
|
||
this bug has been become invalid.
see:
http://www.w3.org/Style/css2-updates/REC-CSS2-19980512-errata.html
Section 17.6 Borders
[2001-10-03] Several popular browsers assume an initial value for
'border-collapse' of 'separate' rather than 'collapse' or exhibit behavior that
is close to that value, even if they do not actually implement the CSS table
model. Therefore the CSS WG proposes to change the initial value to 'separate',
in the expectation that it better matches what users expect it to be.
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#151
shows that we are now compliant.
Status: NEW → RESOLVED
Closed: 25 years ago → 23 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 28•23 years ago
|
||
What's in html.css is not the default value. The default value is here:
http://lxr.mozilla.org/seamonkey/source/content/shared/src/nsStyleStruct.cpp#889
You need to log in
before you can comment on or make changes to this bug.
Description
•