Closed Bug 9191 Opened 25 years ago Closed 23 years ago

Default value of border-collapse incorrect

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED INVALID
Future

People

(Reporter: dbaron, Assigned: ian)

References

Details

(Keywords: css2, Whiteboard: [nsbeta3-])

Attachments

(2 files)

Tested on: mozilla.org 1999-06-30-08-M8, Linux. Test case to be attached. The default value of the border-collapse property, per CSS2, is collapse. This is not happening. It would be acceptable (although not advisable, I think) for ua.css to set border-collapse: separate on table. However, that is not what is happening. The test case to be attached shows that the separated borders model is being used for both table and <div style="display: table"> (using classes...). If the separated borders model were used, the first two tables would look the same as the last two. I think the border and frame attributes of table (only some values of frame) should set border-collapse to separate. It shouldn't be that by default. I highly recommend that you wait until bug 9024 is fixed before fixing this bug, since border-collapse:collapse on empty tables can lead to instability (there are a bunch of asserts on empty tables with border-collapse:collapse, I think). The display glitch in the bottom row of the test case may be related to bug 2886, but may be separate. Someone (I?) should investigate further and file another bug if needed...
Depends on: 9024
Status: NEW → ASSIGNED
Target Milestone: M9
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
I'm reopening this because I believe (from the newsgroups) that the fix was backed out to fix bug 11441. As I said before, I think this should wait until bug 9024 (and any other collapsing border crashes) are fixed. I think when you fix this, you should change the style mapping code for the border attribute and some/all values of the frame attribute to set border- separate: separate, and leave the HTML default as collapse.
Resolution: FIXED → ---
Target Milestone: M9 → M10
Deferring to M10
Target Milestone: M10 → M15
Moving non-beta 1 items to M15
Summary: Default value of border-collapse incorrect → {css2} Default value of border-collapse incorrect
Assignee: peterl → pierre
Status: REOPENED → NEW
Reassigning peterl's bugs to myself.
Status: NEW → ASSIGNED
Accepting peterl's bugs that have a Target Milestone
Target Milestone: M15 → M16
Pushing my M15 bugs to M16
Target Milestone: M16 → M15
Moving table bugs to M15 just to see how many we have.
Keywords: css2
Migrating from {css2} to css2 keyword. The {css1}, {css2}, {css3} and {css-moz} radars should now be considered deprecated in favour of keywords. I am *really* sorry about the spam...
Summary: {css2} Default value of border-collapse incorrect → Default value of border-collapse incorrect
Block-moved to attinasi the bugs related to style inside tables
Assignee: pierre → attinasi
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
> It would be acceptable (although not advisable, I think) for > ua.css to set border-collapse: separate on table. Necessary in fact, because of the way that HTML tables work - cellspacing, etc.
No, the alternative is to set it in the attribute mapping code, but only do so for some border styles.
Er... values of the rules or frame attributes, not border styles.
Karnaze needs to fix the table code to deal with collapsed borders better before we can change the default to collapse. Once we can change the default in html.css to 'border-collapse:collapse' (or better yet, just remove the rule) then we will look at this further to see what the story is with the DIV that has a display:table rule. Moving to M16 to match the dependent bug.
Depends on: 22897
Target Milestone: M15 → M16
Moving to M17 to match dependent bug 22897 (I cannot change the default until collapsed borders work correctly).
Target Milestone: M16 → M17
Now depends on bug 41262 since 22897 was marked a dup...
Depends on: 41262
Keywords: nsbeta3
Target Milestone: M17 → M18
Keywords: correctness
Easy fix once dependent bug is fixed
Whiteboard: [nsbeta3+]
Priority: P3 → P2
Since bug 41262 was nsbeta3-'d, this bug is getting nsbeta3-'d too. Will change the default when collapsing borders work correctly.
Whiteboard: [nsbeta3+] → [nsbeta3-]
Target Milestone: M18 → Future
Netscape's standard compliance QA team reorganised itself once again, so taking remaining non-tables style bugs. Sorry about the spam. I tried to get this done directly at the database level, but apparently that is "not easy because of the shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
there is a proposal in the CSS WG to make this bug INVALID by changing the initial value in the spec...
QA Contact: ian → amar
Reassigning to pierre.
Assignee: attinasi → pierre
Status: ASSIGNED → NEW
Was just working with border-collapse, noticed that it's fixed.
Assignee: pierre → ian
don't know if i'm 100% on topic here but i got some comments on border-collapse, too. i don't get mozilla (2001 101117 win2k) to display the border-collapse:collapse as expected. the w3c spec is at: http://www.w3.org/TR/REC-CSS2/tables.html#propdef-border-collapse also see the testcase png i submitted, comparing mozilla <--> w3c border-collapse rendering. phil.
border-collapse has been disabled for a long time and is planned to be back in m0.9.7.
this bug has been become invalid. see: http://www.w3.org/Style/css2-updates/REC-CSS2-19980512-errata.html Section 17.6 Borders [2001-10-03] Several popular browsers assume an initial value for 'border-collapse' of 'separate' rather than 'collapse' or exhibit behavior that is close to that value, even if they do not actually implement the CSS table model. Therefore the CSS WG proposes to change the initial value to 'separate', in the expectation that it better matches what users expect it to be. http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#151 shows that we are now compliant.
Status: NEW → RESOLVED
Closed: 25 years ago23 years ago
Resolution: --- → INVALID
What's in html.css is not the default value. The default value is here: http://lxr.mozilla.org/seamonkey/source/content/shared/src/nsStyleStruct.cpp#889
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: