Currently Top Sites thumbnails make references towards adding a bookmark. Should this be replaced with 'Add a site'? Is this a new string? See screenshot -- Nightly (09/21) LG Nexus 4 (Android 4.3)

Should read "Add a site" http://cl.ly/image/2E0H0B2u273D

Another string change :(

Comment on attachment 808666 [details] [diff] [review] patch Review of attachment 808666 [details] [diff] [review]: ----------------------------------------------------------------- What happened to the removal? This looks fine.

(In reply to Sriram Ramasubramanian [:sriram] from comment #4) > What happened to the removal? I put it in a separate patch so that if we try to uplift this, we'll only be uplifting one string change, not two.

Comment on attachment 808669 [details] [diff] [review] (Part 2) Remove unused bookmark_add string Review of attachment 808669 [details] [diff] [review]: ----------------------------------------------------------------- Clever ;)

https://hg.mozilla.org/integration/fx-team/rev/c5cb63ccbcbc https://hg.mozilla.org/integration/fx-team/rev/109bda064ff3

https://hg.mozilla.org/mozilla-central/rev/c5cb63ccbcbc https://hg.mozilla.org/mozilla-central/rev/109bda064ff3

Comment on attachment 808666 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): part of the about:home rewrite (follow-up to bug 917394) User impact if declined: empty thumbnails will have confusing placeholder text Testing completed (on m-c, etc.): landed on m-c Risk to taking this patch (and alternatives if risky): low risk, just a string change String or IDL/UUID changes made by this patch: one string change, I'll cc l10n folks

Comment on attachment 808666 [details] [diff] [review] patch Needed for the new new about:home. the l10n community is aware of the string change.