Steps to duplicate: 1) Open the following URL with Firefox latest: https://www.mozilla.org/en-US/firefox/new/#download-fx Expected behavior: * First scene of the download page shown just as viewing /firefox/new/ without #download-fx in the URL. Actual behavior: * Second scene of the download page with instructions plays and then the first scene then plays after the second finishes. Can we keep the second scene from playing at all when download button is hidden (i.e. latest firefox or other scenario)?

The behavior of the second scene showing and then the first scene showing also happens on unsupported platforms like iOS and Firefox OS.

Fix in pull request 1267: https://github.com/mozilla/bedrock/pull/1267

Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/3769b71e9496095270838f514dd471ce8f623d60 If download is not possible, don't show scene2 on /new. See bugs 891562 and 919788. This also prevents scene2 from appearing if you manually update the location hash. Both of these scenarios could cause bogus download stats when the page is loaded in firefox-latest or fxos or an unsupported platform.

Verified on -dev: http://www-dev.allizom.org/en-US/firefox/new/#download-fx Firefox latest: * Sends GA page view for /firefox/new/ and *no* virtual page view Non-Firefox * Sends GA page view for /firefox/new/ and a virtual page view It also doesn't show the second scene for a second and then flip back. Nice job.

fixed on stage http://www.allizom.org/en-US/firefox/new/#download-fx

Ok, I found two bugs. Safari: Visit the URL below, it flips back to scene 1 even though you request scene 2: Scene 1: http://www-dev.allizom.org/en-US/firefox/new/#download-fx Scene 1: http://www.allizom.org/en-US/firefox/new/#download-fx Scene 2 with no images: https://www.mozilla.org/en-US/firefox/new/#download-fx Chrome: The scenes work correct in Chrome, but the instruction images are missing. https://www.allizom.org/en-US/firefox/new/#download-fx

Chris here is a screencast from my tests on Mac in Chrome and Safari 6.1 http://screencast.com/t/s7M9MfKNp. And Windows in Chrome http://screencast.com/t/FrKWwc5t4J

I talked to gauthierm about a possible delay for the download and to give the page a change load the second scene and JS to finish. Let's compare the previous download page and the one that loaded a download when the page loads and where all other bedrock buttons point to. http://www.mozilla.org/en-US/products/download.html?product=firefox-24.0&os=win&lang=en-US The page waits almost 3 seconds before the download pops up. On the proposed page: https://www.allizom.org/en-US/firefox/new/#download-fx The new page waits 600ms before the download shows up. The JS for the old page is here: http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/js/download.js?view=markup HTML for the old page is here: http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/products/download.html?view=markup If we add a delay to the download, it should only happens when the second scene is automatically triggered and shouldn't happen if a user lands directly on scene 1. I don't the delay will damage UX or conversions since users have already take an action of downloading by clicking a button on a previous page.

Would it help if we just display the second scene immediately instead of playing the animation of moving between the 1st and 2nd scene when #download-fx is in the URL and it is an allowed download?

(In reply to Chris More [:cmore] from comment #8) > I talked to gauthierm about a possible delay for the download and to give > the page a change load the second scene and JS to finish. Let's compare the > previous download page and the one that loaded a download when the page > loads and where all other bedrock buttons point to. > > http://www.mozilla.org/en-US/products/download.html?product=firefox-24. > 0&os=win&lang=en-US > > The page waits almost 3 seconds before the download pops up. > This page waits 2.5 seconds if the browser is Safari or a derivative. It uses window.onload for all other browsers. https://www.mozilla.org/en-US/firefox/new/#download-fx uses window.onload as well to trigger showing scene2. The problem we're seeing is because scene2 loads in new images when it appears. Those images get cancelled with the Firefox download starts. To fix this we can load the CSS images in JS and only trigger the FX download when the image load is complete.

(In reply to Chris More [:cmore] from comment #9) > Would it help if we just display the second scene immediately instead of > playing the animation of moving between the 1st and 2nd scene when > #download-fx is in the URL and it is an allowed download? I don't think it would help the issue but is a good idea regardless. The animation on load is distracting.

(In reply to Michael Gauthier [:gauthierm] from comment #11) > (In reply to Chris More [:cmore] from comment #9) > > Would it help if we just display the second scene immediately instead of > > playing the animation of moving between the 1st and 2nd scene when > > #download-fx is in the URL and it is an allowed download? > > I don't think it would help the issue but is a good idea regardless. The > animation on load is distracting. At least it would eliminate the CPU cycles for the animation and the page would render quicker. I would vote for making the animation not play when a user requests #download-fx directly regardless of the fix here.

I can't seem to reproduce the Safari bug when running locally, so we may need to test on a demo server if we need to introduce a delay when initiating scene2/download.

retornam: can you test http://stage2.silverorange.com:8184/en-US/firefox/new/#download-fx with issues described in comment 6 and the original comment 0?

Latest round of improvements in https://github.com/mozilla/bedrock/pull/1275

gauthierm: the changes you pushed to your stage server with the "the popup open call before the gatrack call" seems to have resolved the issue! We will do more testing on Monday AM. retornam: Can you test this? http://stage2.silverorange.com:8184/en-US/firefox/new/#download-fx Browser:behavior 1) IE 6, 7, 8, 9, 10: downloads Firefox auto 2) Safari: downloads Firefox auto 3) Chrome: downloads Firefox auto 4) Firefox old (<23 and not 17 or 10): downloads Firefox auto 5) Firefox new (24): no button, no download 6) Firefox android old: shows play button 7) Firefox android 24: no play button 8) iOS: no button 9) Firefox OS: no button http://stage2.silverorange.com:8184/en-US/firefox/new/ 1) IE 6, 7, 8, 9, 10: button 2) Safari: button 3) Chrome: button 4) Firefox old (<23 and not 17 or 10): button 5) Firefox new (24): no button, no download 6) Firefox android old: shows play button 7) Firefox android 24: no play button 8) iOS: no button 9) Firefox OS: no button

(In reply to Chris More [:cmore] from comment #16) > gauthierm: the changes you pushed to your stage server with the "the popup > open call before the gatrack call" seems to have resolved the issue! We will > do more testing on Monday AM. > > retornam: > > Can you test this? > > http://stage2.silverorange.com:8184/en-US/firefox/new/#download-fx > > Browser:behavior > > 1) IE 6, 7, 8, 9, 10: downloads Firefox auto > > 2) Safari: downloads Firefox auto Works as expected. > > 3) Chrome: downloads Firefox auto Works as expected. > > 4) Firefox old (<23 and not 17 or 10): downloads Firefox auto > > 5) Firefox new (24): no button, no download Works as expected > > 6) Firefox android old: shows play button Works as expected > > 7) Firefox android 24: no play button Works as expected > > 8) iOS: no button > > 9) Firefox OS: no button Works as expected. > > http://stage2.silverorange.com:8184/en-US/firefox/new/ > > 1) IE 6, 7, 8, 9, 10: button Works as expected > > 2) Safari: button Works as expected > > 3) Chrome: button Works as expected > > 4) Firefox old (<23 and not 17 or 10): button Works as expected > > 5) Firefox new (24): no button, no download Works as expected > > 6) Firefox android old: shows play button Works as expected > > 7) Firefox android 24: no play button Works as expected > > 8) iOS: no button Works as expected > > 9) Firefox OS: no button Works as expected Next is to get this up on stage

Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/48a109fe0cededde0d43f6561f62bbd20d253960 Improve use of scenes in /firefox/new. See bug 919788. This makes a few changes: * if you arrive on the page directly from #download-fx the animation is suppressed. * dowload is initiated in an iframe so current page CSS images don't get cancelled before loading. * scene2 is suppressed on Android * fixed bug in IE < 9 going directly to #download-fx * improve inline commenting * use LESS-CSS mixin for transitions in CSS.

It is looking good on -dev: https://www-dev.allizom.org/en-US/firefox/new/#download-fx Look good retornam?

Chris dev looks good from my end. When do we push to prod?

fixed on stage https://www.allizom.org/en-US/firefox/new/#download-fx

fixed on prod https://www.mozilla.org/en-US/firefox/new/#download-fx https://www.allizom.org/en-US/firefox/new/