Closed
Bug 919947
Opened 11 years ago
Closed 11 years ago
Remove stale opacity:0 from animating tabs
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [Australis:M9][Australis:P3])
Attachments
(1 file)
|
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
I don't know if it was intentional that bug 919541 prevented closing tabs from being rendered at all (e.g. even when hovered by the mouse). This patch maintains that behavior, but gets rid of the now-redundant opacity setting.
I don't know if layout manages to optimize opacity:0 enough for it to be just as cheap as visibility:hidden. If it doesn't, this might be a slight perf win. I'm therefore picking a medium priority for this bug.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #809080 -
Flags: review?(mconley)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 809080 [details] [diff] [review]
patch
Review of attachment 809080 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, I like this better. Thanks Dao.
Attachment #809080 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [Australis:P3] → [Australis:M9][Australis:P3][fixed-in-ux]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P3][fixed-in-ux] → [Australis:M9][Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•