Closed
Bug 920589
Opened 11 years ago
Closed 11 years ago
Only show TabsToolbar gradient in classic themes
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [Australis:M9][Australis:P1])
Attachments
(1 file)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
We have this vertical gradient spanning the entire background of the tabstrip in Windows XP when using Luna (blue, silver, olive).
I think this is slowing us down. The gradient is (arguably) useful in classic themes where the titlebar gets a horizontal gradient from the system, and so the vertical gradient helps to make background tab labels easier to read.
But not for Luna. The gradient there is just silly.
And, handily enough, preliminary testing shows that removing this gradient gives us TART wins across the board for at least Windows XP.
Assignee | ||
Comment 1•11 years ago
|
||
Cc'ing people who might be interested in this bug.
Assignee | ||
Comment 2•11 years ago
|
||
This patch makes it so that the gradient is only ever visible when using classic themes.
Updated•11 years ago
|
Attachment #809954 -
Flags: review+
Updated•11 years ago
|
Blocks: australis-tabs-win
Assignee | ||
Comment 3•11 years ago
|
||
Pushed to try.
Baseline: https://tbpl.mozilla.org/?tree=Try&rev=5d8124462175
Patch: https://tbpl.mozilla.org/?tree=Try&rev=c214b551676f
Assignee | ||
Comment 4•11 years ago
|
||
I didn't expect an r+ so fast. :) I'll just land this then, and we'll see what wins we get. Try pushes cancelled.
Assignee | ||
Comment 5•11 years ago
|
||
Landed on UX as https://hg.mozilla.org/projects/ux/rev/bd0548b83afc
Whiteboard: [Australis:M?][Australis:P1] → [Australis:M9][Australis:P1][fixed-in-ux]
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P1][fixed-in-ux] → [Australis:M9][Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•