Closed
Bug 920882
Opened 11 years ago
Closed 11 years ago
[Gaia] Support shrinking UI for NFC sharing function
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(blocking-b2g:1.3+, firefox28 fixed)
Tracking | Status | |
---|---|---|
firefox28 | --- | fixed |
People
(Reporter: frlee, Assigned: gweng)
References
Details
(Whiteboard: [FT:RIL])
Attachments
(6 files, 2 obsolete files)
When users try to share URL/vCards/image/video via NFC tag function, shrinking UI is needed to indicate the sharing process has been started.
Reporter | ||
Updated•11 years ago
|
Comment 1•11 years ago
|
||
Hi Frances,
Here's the spec for shrinking UI, please refer to attachment.
Comment 2•11 years ago
|
||
I also attached an animation for you to reference,
Here's the link:https://www.dropbox.com/s/fu3788ay9i344eo/NFC_%2020131001.mov
Thanks,
Juwei
Comment 3•11 years ago
|
||
This looks like something that system platform team needs to help.
Ivan, could you help to make sure this is in the backlog for system platform team?
Thank you.
Flags: needinfo?(itsay)
Comment 4•11 years ago
|
||
Discussion on the UX draft:
1. If orientation happens in the shrinking UI, we agreed NOT to change the orientation.
2. Both from sender's device and receiver's device, they will have the shrinking UI.
3. Receiver will have slide in animation and sender will have swipe out animation.
4. In the shrinking UI for both receiver and sender, there will have an indicator that indicate users to do the swipe action.
Suggestions:
1. Gaia team suggested to touch to share, not swipe to share.
Comment 5•11 years ago
|
||
5. Will have vibration during shrinking UI on both receiver and sender sides.
6. Once we turn on Bluetooth(no matter it's BT pairing or BT transfer), Bluetooth won't be turned off.
Updated•11 years ago
|
Assignee: nobody → alive
Comment 6•11 years ago
|
||
Kevin, per our discussion, this engineering work will be tracked under NFC team to reduce the communication effort. Regarding the engineering resource tracking, Tim will regularly have the sync-up with system platform team members on their workload. I will also check if there is any impact on the tasks of system platform and your team regularly.
Flags: needinfo?(itsay)
Comment 7•11 years ago
|
||
See also https://bugzilla.mozilla.org/show_bug.cgi?id=860910
We're blocked by this bug and we block the following functional team work(per app).
Reporter | ||
Updated•11 years ago
|
Whiteboard: [FT:RIL, NFCv1.3] → [FT:RIL, 1.3:p1]
Comment 8•11 years ago
|
||
Meeting notes:
Concerning the P2P SENDER device display:
Upon hardware detection of another device, Gecko will fire a system message to system app/nfc_manager so that it can update the UI to indicate another NFC device is nearby.
Depending on User action on that UI, the system app fires a response to the gecko parent, which then relays "onpeerfound" or "onpeerlost" to the application. That event message from gecko to app is fired if, and only if, the application is in the foreground, and has the callbacks defined.
With the callback the application can take action (ie, initiate NFCPeer.sendNDEF(record) to the other device).
Assignee | ||
Comment 9•11 years ago
|
||
Notes from an offline discussion with UX:
* The tilted window should make animation to shrink deeper then bounce back to the normal position.
* If any other activities emerge, like file transferring requests from other already paired Bluetooth devices, or the screen changed due to timeout or user pressed the power button, the whole NFC flow should be seemed as interrupted, and should be terminated immediately.
* Apps should receive a notification that it should prepare to make a NFC/Bluetooth transferring, to let itself paused if it's necessary. This is especially needed when a user is playing a sone/video/slideshow near the end, because the next second user send it out, the content would change to the main page of the app, and make the sharing stuff become ambiguous.
Comment 10•11 years ago
|
||
(In reply to Greg Weng [:snowmantw] from comment #9)
> * Apps should receive a notification that it should prepare to make a
> NFC/Bluetooth transferring, to let itself paused if it's necessary. This is
> especially needed when a user is playing a sone/video/slideshow near the
> end, because the next second user send it out, the content would change to
> the main page of the app, and make the sharing stuff become ambiguous.
Android seems simply bring the app to background(pause/resume).
In this case we could do AppWindow.setVisible(false, true) to put a screenshot overlay.
Assignee | ||
Comment 11•11 years ago
|
||
So our platform can pause an app like that? Because the apps are still need to know the sharing request emerged. For example, if the vide app is playing a video, and the user suddently pair the NFC and start to drag it to send it out, the app at least should know the current video is the sharing target, not the next one changes during the sliding.
Of course it's not a proposal to create a new, special request to notify the app just for UX changing. I think that if the app already needs to know any NFC request in the sharing flow, it can do the pausing thing at the time.
Comment 12•11 years ago
|
||
This is irrelevant to NFC but visibility state control.
// In system
AppWindow.setVisible means mozbrowserAPI:setVisible
// In app
window.addEventListener('visibilitychange', function () {
if (document.hidden) {
// do pause
} else {
// do resume
}
});
Comment 13•11 years ago
|
||
Hi, do we have a clear view on the target milestone on this bug now? Thanks.
Comment 14•11 years ago
|
||
It seems better to finish this bug before sprint5. If you think it isn't reasonable, please update target milestone.
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 5 - 11/22
Updated•11 years ago
|
Whiteboard: [FT:RIL, 1.3:p1] → [FT:RIL]
Updated•11 years ago
|
Assignee: alive → gweng
Assignee | ||
Comment 16•11 years ago
|
||
Need to discuss the events from NFC P2P enable to the UI component, and how to check NFC sending is successful or failed. So I only set feed back, not review.
Attachment #8334479 -
Flags: feedback?(alive)
Assignee | ||
Comment 17•11 years ago
|
||
Test:
window.dispatchEvent(new CustomEvent('nfc-p2pinit')); // If another device is close
window.dispatchEvent(new CustomEvent('nfc-p2pfin')); // If the device is away
Assignee | ||
Comment 18•11 years ago
|
||
According to today's meeting, I would propose some notifications to notify the ShrinkingUI should be tilted or not, and the user has touched on it and sent it out. So the patch would be modified.
Comment 19•11 years ago
|
||
Comment on attachment 8334479 [details]
WIP patch
What is going to be reviewed?
Attachment #8334479 -
Flags: feedback?(alive)
Assignee | ||
Comment 20•11 years ago
|
||
Add some notifications to control the shrinking UI, and to send notification to notify that user has sent it out.
I don't know whether this should be reviewed or not, because we may have some discussions with people are implementing NFC manager. So I set feedback flag first.
Attachment #8334479 -
Attachment is obsolete: true
Attachment #8336020 -
Flags: feedback?(alive)
Assignee | ||
Comment 21•11 years ago
|
||
Comment on attachment 8336020 [details]
WIP patch
Find some detailed bug; need to do some adjust.
Attachment #8336020 -
Flags: feedback?(alive)
Assignee | ||
Comment 22•11 years ago
|
||
About communication with ShrinkingUI:
ShrinkingUI will listen these events:
'shrinking-start' // Start shrinking
'shrinking-stop' // Stop shrinking
'shrinking-receiving' // Do receiving effects as UX spec
ShrinkingUI will send out this event:
'shrinking-sent' // User has tapped on app and dragged it out.
Assignee | ||
Comment 23•11 years ago
|
||
Follow the new event way to trigger shrinking effects.
BTW: The Travis dead on irrelevant test: event I remove all my code, it still failed.
Attachment #8336020 -
Attachment is obsolete: true
Attachment #8337508 -
Flags: review?(alive)
Comment 24•11 years ago
|
||
Comment on attachment 8337508 [details]
Patch
Some more comments.
Attachment #8337508 -
Flags: review?(alive)
Assignee | ||
Comment 25•11 years ago
|
||
Comment on attachment 8337508 [details]
Patch
Fixed.
Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/14502887
Attachment #8337508 -
Flags: review?(alive)
Comment 26•11 years ago
|
||
Comment on attachment 8337508 [details]
Patch
r+ with nits.
I'd like you have an unit test or integration test for this, please file a followup to do.
Attachment #8337508 -
Flags: review?(alive) → review+
Comment 27•11 years ago
|
||
Hi Greg,
Here is the background image for shrinking UI!
Thanks!
Comment 28•11 years ago
|
||
Arrow updated.
Color: 00aacc
Assignee | ||
Comment 29•11 years ago
|
||
Ok, thanks.
Comment 30•11 years ago
|
||
@1.5 assets updated.
Thanks!
Assignee | ||
Comment 31•11 years ago
|
||
Comment on attachment 8337508 [details]
Patch
Because the screenshot method and some UX design added, Alive may take a look.
Attachment #8337508 -
Flags: review+ → review?(alive)
Assignee | ||
Comment 32•11 years ago
|
||
Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/14636643
Comment 33•11 years ago
|
||
Comment on attachment 8337508 [details]
Patch
nits
Attachment #8337508 -
Flags: review?(alive) → review+
Assignee | ||
Comment 34•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox28:
--- → fixed
Comment 35•11 years ago
|
||
Update spec due to bug 963010
Tap on Home button should be no function while NFC pairing.
You need to log in
before you can comment on or make changes to this bug.
Description
•