Closed
Bug 921033
Opened 11 years ago
Closed 11 years ago
Make InterAppMessageEvent to use webidl event codegen
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
(deleted),
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
Patch coming
Assignee | ||
Comment 1•11 years ago
|
||
#include "mozilla/dom/MozInterAppMessageEvent.h" is a bit hack since we need
to be able to #include both MozInterAppMessageEvent and InterAppComm
in the binding code so that things compile.
https://tbpl.mozilla.org/?tree=Try&rev=55ac207829a0
At least this compiles locally, but we don't have any tests so this may or may not break stuff.
Attachment #810602 -
Flags: review?(gene.lian)
Comment 2•11 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #1)
> Created attachment 810602 [details] [diff] [review]
> patch
>
> #include "mozilla/dom/MozInterAppMessageEvent.h" is a bit hack since we need
> to be able to #include both MozInterAppMessageEvent and InterAppComm
> in the binding code so that things compile.
This is awesome! Thanks for cleaning it up. Testing your patch.
>
> https://tbpl.mozilla.org/?tree=Try&rev=55ac207829a0
> At least this compiles locally, but we don't have any tests so this may or
> may not break stuff.
I apologize for not having tests. It's under way working. I'll make it on V1.3.
Updated•11 years ago
|
Depends on: inter-app-comm-api
Comment 3•11 years ago
|
||
Comment on attachment 810602 [details] [diff] [review]
patch
Review of attachment 810602 [details] [diff] [review]:
-----------------------------------------------------------------
It's working great. Thank you! Please go ahead to land. r=gene
Attachment #810602 -
Flags: review?(gene.lian) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks for testing!
Assignee | ||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•11 years ago
|
Blocks: inter-app-comm-api
No longer depends on: inter-app-comm-api
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•