Closed
Bug 921330
Opened 11 years ago
Closed 11 years ago
Mac sync unwind not working
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: BenWa, Assigned: bugzilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
I'm trying the SyncProfile for IO markers and I'm getting only the leaf. FramePointerStackWalk is being called but it's not unwinding anything. My guess is TickSample::PopulateContext is wrong. It's getting the sp/fp when inside PopulateContext which aren't good values once we return from that function.
Assignee | ||
Comment 1•11 years ago
|
||
Can you please give this try build a shot and let me know if this looks better? https://tbpl.mozilla.org/?tree=Try&rev=6347fc67bc09
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Flags: needinfo?(bgirard)
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
I tried this out on a hackintosh VM and I got this: http://people.mozilla.org/~bgirard/cleopatra/#report=4941e6a308c1acf9b0ce22888ea6eec4c85d2567 I'm seeing stacks in the I/O markers...
Reporter | ||
Comment 5•11 years ago
|
||
Ahh it works now. I think I tested with the wrong profiler options selected. It seems to inherit the options you have selected for sync unwinding and I didn't have 'stackwalk' checked. Things work now.
Assignee | ||
Updated•11 years ago
|
Attachment #811339 -
Flags: review?(bgirard)
Reporter | ||
Updated•11 years ago
|
Attachment #811339 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Try build in comment 1. https://hg.mozilla.org/integration/mozilla-inbound/rev/5907769bfe89
https://hg.mozilla.org/mozilla-central/rev/5907769bfe89
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•