Ken Chang[:kenkai] Reporter
	Description • 11 years ago

User should be able to see 2 different icons for voicemails and call forwarding indicating each subscription's status.

	Kai-Chih Hu [:khu]
	Comment 1 • 11 years ago

The effort should be minor. UX won't be changed. Only a Web API will be changed, and the new API will return the information about SIM.

	Kai-Chih Hu [:khu]
	Comment 2 • 11 years ago

Arthur, may I know what's the target milestone in your mind for this bug? Thanks.

	Kai-Chih Hu [:khu]
	Comment 3 • 11 years ago

Plan to land in the 1st week of sprint 6.

	Ken Chang[:kenkai] Reporter
	Comment 4 • 11 years ago

This bug is supposed to block bug 938438.

	Ken Chang[:kenkai] Reporter
	Comment 5 • 11 years ago

After checking user story, this is 1.4 feature.

	Anshul
	Comment 6 • 11 years ago

Ken, this seems like a pretty basic bug that we need to add in 1.3. Sandip what do you think?

	Sandip Kamat
	Comment 7 • 11 years ago

(In reply to Anshul from comment #6)
> Ken, this seems like a pretty basic bug that we need to add in 1.3. Sandip
> what do you think?

Hi Anshul, Most of the user stories that distinguish source or destinations SIMs in UI are targeted for 1.4 (e.g. indicating SIMs in call history, message inbox and voicemails UI etc). This was done as a trade off to get 1.3 committed user stories landed in time with high confidence. Even if we get this one in, there will be inconsistencies in other areas where SIMs are not distinguished in those use cases. I am not opposed to having this one in 1.3 if it can happen with no risks, just do not want some other critical (committed) user stories to be traded off for these. Hope this helps.

	Anshul
	Comment 8 • 11 years ago

Sandip, thanks for your prompt response. Other bugs like call history, messages per SIM are good to have but not necessary. The voicemail on the other hand is needed as other wise we would only show the voicmaail information from the last SIM we got the voicemail on, which is incorrect. I think of this very similar to two signal strength icons we already have now for each SIM.

	Sandip Kamat
	Comment 9 • 11 years ago

(In reply to Anshul from comment #8)
> The voicemail on the other hand is needed as other wise we would only show the voicmaail
> information from the last SIM we got the voicemail on, which is incorrect. I
> think of this very similar to two signal strength icons we already have now
> for each SIM.

yes, we had internally discussed in the past reviews. The limitation here will be the icon will show a voicemail for either SIM. So the user needs to really clear it by calling one SIM at a time (I understand it is a hard trade off we had to make to limit scope). But if it can come in 1.3 timeframe without risks, I am okay with it. (Given that it is too late for 1.3 to commit).

	José Antonio Olivera Ortega [:jaoo]
	Comment 10 • 11 years ago

I agree with the comment made by Anshul in comment #8. Call settings, specially call forwarding, wont be complete until we fix this bug. We will fix bug 928294 for v1.3 but the call forwarding feature for multi ICC card devices wont be complete until we fix this bug.

	Sandip Kamat
	Comment 11 • 11 years ago

In general, if it is a dependency for a committed feature, that's a new data which we did not have before. We should fix it for that then. Can someone provide the risk assessment for this fix to land in 1.3?

	Arthur Chen [:arthurcc][inactive after 6/30] Assignee
	Comment 12 • 11 years ago

I think it is less risk to display different icons for call forwarding, but we may not able to finish it before branching.

As for voicemail, I checked the code and found that things are not as what comment 1 described. We don't have an icon for voicemail even on single sim devices. So it might be too late to define the behavior and to add the icon.

	Anshul
	Comment 13 • 11 years ago

(In reply to Arthur Chen [:arthurcc] from comment #12)
> I think it is less risk to display different icons for call forwarding, but
> we may not able to finish it before branching.
> 
> As for voicemail, I checked the code and found that things are not as what
> comment 1 described. We don't have an icon for voicemail even on single sim
> devices. So it might be too late to define the behavior and to add the icon.
Hello Arthur, sorry my original comments were misleading. What I meant to say is two different voicemail notifications from each sim.

	Arthur Chen [:arthurcc][inactive after 6/30] Assignee
	Comment 14 • 11 years ago

Hi Etienne, can you provide a rough assessment for the change described in comment 13 in terms of risk and effort?

	Etienne Segonzac (:etienne)
	Comment 15 • 11 years ago

Well I'm confused since we _do have_ an icon in the status bar for voicemail [1].
Not sure that's what this bug is about...

But anyway, we'll have to sort out the issue with the |ril.iccInfo.mbdn| setting before we can add any proper voicemail+dsds support so we should target 1.4.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/voicemail.js#L20-21

	Arthur Chen [:arthurcc][inactive after 6/30] Assignee
	Comment 16 • 11 years ago

Carrie, Fang, it seems we need icons for call forwarding on different sim cards. We can use either static images or just use the current icon along with a text indicating the sim cards.

	Arthur Chen [:arthurcc][inactive after 6/30] Assignee
	Comment 17 • 11 years ago

Use bug 975918 to track the voice mail part.

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 18 • 11 years ago

Hi Arthur,

Fang is taking care of the icon design. Thanks!

	Fang Shih [:fang]
	Comment 19 • 11 years ago

Hi Arthur,

As you said, We can use the current call forwarding icon with a number indicating the SIM cards. The attached image shows the look. Thanks!

	Arthur Chen [:arthurcc][inactive after 6/30] Assignee
	Comment 20 • 11 years ago

Jose, could you help review settings/js/call.js and system/js/call_forwarding.js? To add unit tests, I make it as a new module and extend it to support multiple sims.

Alive, could you help review the overall system app modifications? Thanks!

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 21 • 11 years ago

Comment on attachment 8385205 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/16812

greak work, r+ with nits

	José Antonio Olivera Ortega [:jaoo]
	Comment 22 • 11 years ago

Comment on attachment 8385205 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/16812

(In reply to Arthur Chen [:arthurcc] from comment #20)
> Created attachment 8385205 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/16812
> 
> Jose, could you help review settings/js/call.js and
> system/js/call_forwarding.js? To add unit tests, I make it as a new module
> and extend it to support multiple sims.

LGTM, thanks for adding the support for multi ICC cards. r=me

I tested the work on peak and fugu device and everything seems to work correctly. Thanks for adding some tests too.

	Arthur Chen [:arthurcc][inactive after 6/30] Assignee
	Comment 23 • 11 years ago

Thanks Jose and Alive.

master: c92859677608a214b82aadadb2f57cbb0fe3f3e8

	Eric Chang [:ericcc] [:echang]
	Comment 24 • 11 years ago

Verified okay with v1.4 on Fugu.

GAIA_REV=441c4bcd8ac4f8c01a9bc5a2f8d64eaa87844803
GECKO_REV=0c18beacb37a7e1e80bcf6d46cc8ff9a18c0c653
GAIA_BRANCH=mozillaorg/v1.4
GECKO_BRANCH=mozillaorg/v1.4
BUILD_TAG=jenkins-B2G.v1.4.0.fugu-25
BuildID=20140416041552