Closed
Bug 921437
Opened 11 years ago
Closed 11 years ago
Restore perf-spewer include files in js/src/jit
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dougc, Assigned: dougc)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The jit/PerfSpewer.h include file appears to have
been removed from a few files in which it is still
necessary. It is an optional build feature, but
quite useful for developers.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #811066 -
Flags: review?(ehsan)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 811066 [details] [diff] [review]
Restore perf-spewer include files in js/src/jit
Review of attachment 811066 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for breaking this. :(
But looking at PerfSpewer.h, it only does something meaningful when JS_ION_PERF is #defined, which is why I didn't get build failures when I removed these includes. Would you mind wrapping these three #includes in #ifdef JS_ION_PERF please?
Attachment #811066 -
Flags: review?(ehsan) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Found one more that needed restoring in x64/Trampoline-x64.cpp.
It was possible to conditionalize a few more instances. Is
this the preferred style?
Tested x64 and x86 builds, with and without the perf feature
enabled.
Thank you for working to clean up the source.
Attachment #811066 -
Attachment is obsolete: true
Attachment #811183 -
Flags: review?(ehsan)
|
|
||
Updated•11 years ago
|
Attachment #811183 -
Flags: review?(ehsan) → review+
|
|
||
Comment 4•11 years ago
|
||
Thanks!
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•