Closed
Bug 921584
Opened 11 years ago
Closed 11 years ago
When compiling ProxyObject.cpp: "Runtime.h:1434:17: warning: inline function 'bool JSRuntime::isAtomsZone(JS::Zone*)' used but never defined [enabled by default]"
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dholbert, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Build warning noticed today, when compiling mozilla-inbound:
{
In file included from /mozilla-inbound/js/src/jscntxt.h:15:0,
from /mozilla-inbound/js/src/gc/Zone.h:13,
from /mozilla-inbound/js/src/jsgcinlines.h:12,
from /mozilla-inbound/js/src/vm/ProxyObject.cpp:9:
/mozilla-inbound/js/src/vm/Runtime.h:1434:17: warning: inline function 'bool JSRuntime::isAtomsZone(JS::Zone*)' used but never defined [enabled by default]
inline bool isAtomsZone(JS::Zone *zone);
^
}
Reporter | ||
Comment 1•11 years ago
|
||
hg bisect says this was introduced by:
{
changeset: 148911:5b35eb07b456
user: Ehsan Akhgari <ehsan@mozilla.com>
date: Thu Sep 26 18:34:54 2013 -0400
summary: Bug 921130 - Minimize the #includes in js/src/jit; r=luke
}
http://hg.mozilla.org/mozilla-central/rev/5b35eb07b456
Blocks: 921130
Assignee | ||
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
See bug 921583?
Comment 5•11 years ago
|
||
Comment on attachment 811341 [details] [diff] [review]
Patch (v1)
Review of attachment 811341 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jscompartment.h
@@ +20,5 @@
> }
>
> +namespace gc {
> +template<class Node> class ComponentFinder;
> +}
Is this necessary? Maybe it avoids some bootlegging? We generally don't worry about bootlegging much -- it's so hard to avoid -- but it's not a big deal either way.
Attachment #811341 -
Flags: review?(luke) → review+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to comment #5)
> Comment on attachment 811341 [details] [diff] [review]
> --> https://bugzilla.mozilla.org/attachment.cgi?id=811341
> Patch (v1)
>
> Review of attachment 811341 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: js/src/jscompartment.h
> @@ +20,5 @@
> > }
> >
> > +namespace gc {
> > +template<class Node> class ComponentFinder;
> > +}
>
> Is this necessary? Maybe it avoids some bootlegging? We generally don't worry
> about bootlegging much -- it's so hard to avoid -- but it's not a big deal
> either way.
I wrote several versions of this patch locally, and this was required in one of them. It's kind of more correct to do the fwd declaration here since the header references ComponentFinder, so I'd prefer to leave it in.
At any rate, I'll land this patch if inbound ever reopens.
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•