Closed
Bug 921917
Opened 11 years ago
Closed 11 years ago
B2G MMS: Provide a flag to let user be able to request read report or not when sending MMS.
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ctai, Assigned: ctai)
References
Details
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
As a sender, FFOS is capable of enabling/disabling to request MMS read report from the receiver.
|
||
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Summary: B2G MMS: Provide a flag to let user can request read report or not when sending MMS. → B2G MMS: Provide a flag to let user be able to request read report or not when sending MMS.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ctai
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #823811 -
Flags: review?(gene.lian)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 823811 [details] [diff] [review]
bug-912917.patch v1.0
Review of attachment 823811 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! Thank you! r=gene
::: dom/mobilemessage/src/gonk/MmsService.js
@@ +953,5 @@
> msg.headers["x-mms-priority"] = 129;
> + try {
> + msg.headers["x-mms-read-report"] =
> + Services.prefs.getBoolPref("dom.mms.requestReadReport");
> + }catch (e) {
nit: add one space after "}".
::: modules/libpref/src/init/all.js
@@ +4427,5 @@
>
> // Debug enabler for MMS.
> pref("mms.debugging.enabled", false);
>
> +// Request read report while sending MMS
nit: add a period in the end.
Attachment #823811 -
Flags: review?(gene.lian) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Fixed according to gene's comments
Attachment #823811 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
Assignee | |
Updated•11 years ago
|
Component: DOM: Device Interfaces → RIL
Product: Core → Firefox OS
Target Milestone: mozilla28 → ---
|
||
Comment 9•11 years ago
|
||
This landed before gecko 28 branched so will be in 1.3.
blocking-b2g: 1.3? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•