Closed
Bug 922214
Opened 11 years ago
Closed 11 years ago
Add console.exception
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: fitzgen, Assigned: denschub)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
https://github.com/DeveloperToolsWG/console-object/blob/master/api.md#consoleexceptionerror-object-object-
> An alias for console.error.
|
Reporter | |
Comment 1•11 years ago
|
||
Possibly a good-first-bug, but I wouldn't know how to mentor it.
|
||
Comment 2•11 years ago
|
||
not a good first bug. :)
|
||
Updated•11 years ago
|
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8340676 -
Flags: review?(mihai.sucan)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8340676 [details] [diff] [review]
Proposed implementation of console.exception()
Review of attachment 8340676 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you Dennis for the patch! This is looking good, but one of the webconsole tests fails:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_console_extras.js | only two messages are displayed - Got 3, expected 2
Please make sure you always run all of the tests.
Attachment #8340676 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Uh, I'm sorry. Here we are, with passing tests. :)
Attachment #8340676 -
Attachment is obsolete: true
Attachment #8341201 -
Flags: review?(mihai.sucan)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8341201 [details] [diff] [review]
Proposed implementation of console.exception()
Thank you for the updated patch! This looks good. r+
Try push https://tbpl.mozilla.org/?tree=Try&rev=7b7c7340f503
Once it's all green, I will land the patch.
Attachment #8341201 -
Flags: review?(mihai.sucan) → review+
|
|
||
Updated•11 years ago
|
Keywords: dev-doc-needed
|
|
||
Comment 7•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•