Closed Bug 922520 Opened 11 years ago Closed 11 years ago

Disable pseudo derecurse during pgo second pass

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

That hasn't been tested, and i'm pretty sure it's full of tail.
This kind of addresses the concern about pgomerge in bug 921003.
Attachment #812475 - Flags: review?(gps)
Comment on attachment 812475 [details] [diff] [review] Disable MOZ_PSEUDO_DERECURSE on the second PGO pass Review of attachment 812475 [details] [diff] [review]: ----------------------------------------------------------------- Doesn't seem like it will harm anything except for perf. I'd like to think we can still do some tiers flattened while using the profile. Please document the reasoning for this in the code.
Attachment #812475 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #2) > Comment on attachment 812475 [details] [diff] [review] > Disable MOZ_PSEUDO_DERECURSE on the second PGO pass > > Review of attachment 812475 [details] [diff] [review]: > ----------------------------------------------------------------- > > Doesn't seem like it will harm anything except for perf. > > I'd like to think we can still do some tiers flattened while using the > profile. Note pseudo derecurse is *not* enabled on releng builds yet anyways.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: