Closed Bug 922574 Opened 11 years ago Closed 11 years ago

[wasabi][CDMA][Call waiting] When user presses "Switch" button, there is no visual effect, no way to know if indeed button is pressed.

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 verified)

Status:
VERIFIED FIXED
Milestone:
1.2 C3(Oct25)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- verified

People

(Reporter: echu, Assigned: gsvelto)

Details

(Whiteboard: [FT:RIL])

Attachments

(4 files)

video
(deleted), video/3gpp
Details
btn_switchlines_press.png
(deleted), image/png
Details
[PATCH] Added a pressed state to the switch-calls button
(deleted), patch
etienne
: review+
Details | Diff | Splinter Review
[PULL REQUEST] Added a pressed state to the switch-calls button
(deleted), text/html
Details
No description provided.
CDMA already has the limitation to show which call is on-hold and which is active, so I suggest a visual effect for user to know he/she does press the "Switch" button can at least help user to make sure the action being taken. * Build Number Gaia: 1e9470b9b6df630eddf1c4c8b25b3170ee786b0e Gecko: 31cc146c80e45d87211c647c5601b3cd7b6234f8 BuildID 20131001031552 Version 26.0a2 http://release1-qa.corp.tpe1.mozilla.com:8080/view/B2G.v1.2.0/job/B2G.v1.2.0.wasabi/ * Reproduce Steps 1. MO a call. 2. MT a call to DUT 3. Answer 2nd call and will see the switch button. 4. Press the button to do call switch. * Expected Result Visual effect of button being pressed can be seen. * Actual Result No visual effect. * Occurrence rate 100%
blocking-b2g: --- → koi?
Summary: [wasabi][CDMA][Call waiting → [wasabi][CDMA][Call waiting] When user presses "Switch" button, there is no visual effect, no way to know if indeed button is pressed.
Whiteboard: [FT:RIL]
Attached video video (deleted) —
hi Neo, please provide both UX and visual proposal to resolve this unfriendly design.
Assignee: nobody → nhsieh
blocking-b2g: koi? → koi+
Attached image btn_switchlines_press.png (deleted) —
Hi Everyone, Please check attached file. Thanks
Blocks: 890807
Assignee: nhsieh → kchang
No longer blocks: 890807
Gabriele, Need your help to change the visual in Gaia.
Assignee: kchang → gsvelto
OK, I'll fix this right away.
Target Milestone: --- → 1.2 C3(Oct25)
This is a simple patch that adds a pressed state to the CDMA call-waiting button to give the user some visual feedback to the action.
Attachment #815882 - Flags: review?(etienne)
Comment on attachment 815882 [details] [diff] [review] [PATCH] Added a pressed state to the switch-calls button Review of attachment 815882 [details] [diff] [review]: ----------------------------------------------------------------- All good.
Attachment #815882 - Flags: review?(etienne) → review+
Pointer to Github pull-request
Attachment #816541 - Attachment description: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12813 → [PULL REQUEST] Added a pressed state to the switch-calls button
Merged in gaia/master 43ecddd2ebb87065728656dde61eb583c8549576 This needs uplifting to v1.2
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v1.2: --- → affected
Resolution: --- → FIXED
Uplifted 43ecddd2ebb87065728656dde61eb583c8549576 to: v1.2: 94e3088c56c7348655ae76613defd126426cc722
status-b2g-v1.2: affected → fixed
verified on Wasabi Gaia: 94e3088c56c7348655ae76613defd126426cc722 Gecko: 292baf182d8778772335fd2f6fa84eb82e31b906 BuildID 20131015101245 Version 26.0a2
Status: RESOLVED → VERIFIED
status-b2g-v1.2: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: