Description: When the user attempts to make a video on the web be full screen, two confirmation buttons appear that read "Don't Share" and "Share" along with the words "<video/website> is now fullscreen." If the user presses "Share", the video remains in full screen; pressing the "Don't Share" takes the video out of full screen. This was tested using YouTube and Vimeo. Repro Steps: 1) Updated Buri to Build ID: 20130929040201 2) Launch the Browser app 3) Navigate to www.vimeo.com 4) Play a video (make full screen if needed) Actual: Confirmation buttons displayed read "Don't Share" and "Share" Expected: Confirmation buttons displayed read "Deny" and "Share" Environmental Variables Device: Buri Build ID: 20130929040201 Gecko: http://hg.mozilla.org/mozilla-central/rev/e56505c62aba Gaia: c6c1b9bbb50d3a5a27e2c57e2b52746fe73ac86f Platform Version: 27.0a1 Notes: Repro frequency: 100% See attached: FullScreenConfButtons.jpg & logcat.txt

This is a regression from the getUserMedia changes.

Can someone from UX comment here if this is a blocker for release?

(In reply to Jason Smith [:jsmith] from comment #3) > Can someone from UX comment here if this is a blocker for release? In other words, I'm looking to know if UX wants to nominate this to block or not and why.

Flagging Jacqueline to advise, but generally it's not up to us to block/not block a feature like this. Usually, it's the PM for the feature itself. Who's the best person for that for gUM/webRTC?

(In reply to Stephany Wilkes from comment #5) > Flagging Jacqueline to advise, but generally it's not up to us to block/not > block a feature like this. Usually, it's the PM for the feature itself. > Who's the best person for that for gUM/webRTC? Well right, but they usually want UX's opinion on this to be able to make that judgment call. I'm holding on noming this right now because I need to know if UX wants push to block on this or not.

Yes - and Jacqueline is flagged. She'll be back in the office after Summit travel today.

I'm not sure why this needs UX input? It's indeed a bug.

Fix permission dialog button text by checking permission type.

Comment on attachment 814695 [details] https://github.com/mozilla-b2g/gaia/pull/12737 Could you instead allow the button labels to be different for all types? That would allow languages other than English to use more specific button label for different permission types. Thank you for spot this bug though. I won't stop you if you think I should r+ this patch and do the things above in another bug.

Modified travis: https://travis-ci.org/mozilla-b2g/gaia/builds/12406081

I retried three times but always have 1) [communications-contacts] Matching duplicate contacts UI Test Suite duplicate contact details should show the duplicate contact name and highlight it: Error: timeout of 2000ms exceeded at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3680) 2) [communications-contacts] Matching duplicate contacts UI Test Suite duplicate contact details should show the duplicate contact image: Error: timeout of 2000ms exceeded at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3680) I decide to merge, please backout if somebody thinks the error is caused by me.

Can you ask for 1.2 approval here? This cleans up a regression that will improve clarity for the user in permission dialogs.

Comment on attachment 814695 [details] https://github.com/mozilla-b2g/gaia/pull/12737 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]:

Alive - Can you fill in the approval form above?

It's part of gUM voice support for 1.2

Uplifted 0aa42224ca83085db2a11d6d60796a64f5f2951b to: v1.2: 317c3b1fddc3f39af1e04418e365ca9d6b80df6a

Uplifted 0aa42224ca83085db2a11d6d60796a64f5f2951b to: v1.3 already had this commit

Bug has been fixed - removing flag