Closed
Bug 923060
Opened 11 years ago
Closed 11 years ago
xpcshell not working with MOZ_PSEUDO_DERECURSE skipping
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: gps, Assigned: glandium)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
My xpcshell binary fails to start with MOZ_PSEUDO_DERECURSE set to 1. Add no-skip works around the problem.
The binary starts, then exits immediately with a 1 exit code.
Reporter | ||
Comment 1•11 years ago
|
||
Look like .xpt files aren't getting installed (among other things).
Assignee | ||
Comment 2•11 years ago
|
||
I thought all the xpt stuff was done with install manifests. It's not. Installing in dist/bin is still done in rules.mk, presumably because of FINAL_TARGET.
It would be interesting to see why your "bad" build has some files that the other doesn't.
Attachment #813086 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 813086 [details] [diff] [review]
XPIDL_SOURCES impacts the libs tier
Review of attachment 813086 [details] [diff] [review]:
-----------------------------------------------------------------
We abandoned doing the xpt foo properly because it was just beyond the pain threshold for the bug. Now that we have dist/bin under manifest control, it's very tempting to just do that now.
Attachment #813086 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #3)
> We abandoned doing the xpt foo properly because it was just beyond the pain
> threshold for the bug. Now that we have dist/bin under manifest control,
> it's very tempting to just do that now.
I don't think that's possible until FINAL_TARGET can be computed in recursivemake.py.
Reporter | ||
Comment 5•11 years ago
|
||
Yep. I filed bug 923080 with the proper dependency on FINAL_TARGET.
Reporter | ||
Comment 6•11 years ago
|
||
Flags: in-testsuite-
Comment 7•11 years ago
|
||
cc-ing sworkman. He met me yesterday while he debugging an XPCshell bustage that looked to happen with incremental build, but *not* happen with same changeset with a clobber build.
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to John O'Duinn [:joduinn] from comment #7)
> cc-ing sworkman. He met me yesterday while he debugging an XPCshell bustage
> that looked to happen with incremental build, but *not* happen with same
> changeset with a clobber build.
You shouldn't have seen this failure in automation: only on local builds that have opted in to MOZ_PSEUDO_DERECURSE. And, the regression range for this bug was only a few hours on inbound. I highly doubt you hit this.
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•