Tested using Unagi, v1.2, Moz RIL, Gecko-b318b86.Gaia-5e0d0df. In Settings -> Cellular&Data -> Network operator -> Network type Current options for WCDMA devices are: wcdma/gsm gsm wcdma Proposed translations already used in v1.1/v1.0.1: Automatic 2G only 3G only

Certification blocker for launching v1.2. Nominating accordingly.

koi+ as it is a cert blocker

This issue was introduced by supporting CDMA in v1.2. A phone may support combination of network modes. Please consult UX for the detail strings of the combination.

Neo, can you help on this?

So, Is this certification blocker? This is not an obvious issue. Because if we want to consider any one of these names. Like 3G, 3.5G, Edge, GPRS, GSM and Dual SIM..We will have lots of options to use. I think it's depends on partner's requirement. What do you think?

This is related to bug 910111. All possible options are: wcdma/gsm gsm wcdma wcdma/gsm-auto cdma/evdo cdma evdo wcdma/gsm/cdma/evdo We should consider all possible combination (i.e. devices support GSM, CDMA, or GSM + CDMA) based on requirements and define proper strings for them.

This issue is related to bug 903232. When network modes will be displayed accordingly to device capabilities(bug 903232), then we need this bug to fix that WCDMA modes change to the same names that we use in the v1-train: wcdma/gsm --> Automatic gsm --> 2G only wcdma --> 3G only wcdma/gsm-auto --> Honestly, I do not know the difference between wcdma/gsm and wcdma/gsm-auto, Can you describe it? In regard of the other network capabilities(CDMA), we did not use it before so I do not have official translation, we can track them in bug 910111 as you suggested and keep this bug for CDMA ones that we already used in v1-train.

wcdma/gsm-auto is a kind of wcdma/gsm but gsm is more perfered.

Reference http://android.stackexchange.com/questions/28553/change-wcdma-to-gsm-automatically since bug 903232 will hide unrelated CDMA types, we could focus on provide these 4 types with user friednly name. in our context, I suggest to use wcdma/gsm --> 3G preffered (left 'Automatic' for DSDS wcdma/gsm/cdma/evdo mode) gsm --> 2G only wcdma --> 3G only wcdma/gsm-auto --> 2G preffered Neo, how do you think?

Comment on attachment 816910 [details] pull request redirect to github Thanks for the patch! Please check my comments in github. And I would suggest to detect the capability of the device (using getSupportedNetworkInfo in settings/utils.js) and assign corresponding strings. For GSM devices, we keep using Automatic, 2G only, 3G only, 2G preferred. For CDMA devices or GSM + CDMA devices, we can use the terms as the reference provided in comment 9. By doing this we don't need to update the strings when we enable CDMA features in the future.

Is there going to be a way to test those strings if they're device-specific?

Comment on attachment 816910 [details] pull request redirect to github Use three maps (GSM only, CDMA only, Dual stack) detected by result.gsm/result.cdma GSM only, CDMA only mode will follow [Automatic, 2G only, 3G only] pattern. Dual stack mode will use [GSM, CDMA(UPPER words), GSM preffered.., Automatic] pattern ask for review again

Comment on attachment 816910 [details] pull request redirect to github r=me with the github comments addressed. Thanks for the patch!

Axel, I think we can mock different devices by tweaking some variable in the unit tests.

merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/7c6a7b1bfb8a33ccf8af64c83c5100f26eb211c1 thanks! we can use build-time customization in network.json file to put any order of network modes

Uplifted 7c6a7b1bfb8a33ccf8af64c83c5100f26eb211c1 to: v1.2: fc6ee255e10c7ec1762fe1f54f28d01fb7aa0f94

Verified Fixed on Aurora 1.2 Buri and Leo devices. The Network Type displays: WCDMA preferred, GSM, WCDMA, GSM preferred, EVDO preferred, CDMA, EVDO, Automatic. - Leo 1.2 - Gaia dbcc171eae6b4d9d168a48291d5ea54c7580561a SourceStamp 7ca5d1e81d37 BuildID 20131017004001 Version 26.0a2 - Buri 1.2 - Gaia dbcc171eae6b4d9d168a48291d5ea54c7580561a SourceStamp 7ca5d1e81d37 BuildID 20131017004001 Version 26.0a2

Wasabi 1.2 Gaia mozillaorg/v1.2 - 1fd315337d8ae891c3024e4c682c4c50797ea40e Gecko mozillaorg/v1.2 - 66bc401ea42298f15a24e38042ed4886e10b9382 The network type displays: Automatic, 2G only, 3G only build with gaia/distribution/ network.json ============ { "types": [ "cdma/evdo", "cdma", "evdo" ] } settings.json ============= { "ril.radio.preferredNetworkType":"cdma/evdo" }

(In reply to Askeing Yen[:askeing] from comment #20) > Wasabi 1.2 > Gaia mozillaorg/v1.2 - 1fd315337d8ae891c3024e4c682c4c50797ea40e > Gecko mozillaorg/v1.2 - 66bc401ea42298f15a24e38042ed4886e10b9382 > > The network type displays: Automatic, 2G only, 3G only https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/carrier.js#L752 https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L172 Verified on 1.2 wasabi.