Closed Bug 923156 Opened 11 years ago Closed 11 years ago

[OSX] Moving the bookmarks toolbar items into the navbar causes weird vertical alignment issues with the navbar and some buttons

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- affected
firefox31 --- affected

People

(Reporter: Gijs, Assigned: jaws)

References

Details

(Whiteboard: [Australis:P4+])

Attachments

(3 files, 1 obsolete file)

Jumbled-up button screenshot
(deleted), image/png
Details
Screenshot from Nightly 04-22 Win8
(deleted), image/png
Details
Patch v.1
(deleted), patch
Gijs
: review+
Details | Diff | Splinter Review
Attached image Jumbled-up button screenshot (deleted) —
STR: 1. Open UX 2. Enter customize mode 3. Move the bookmark toolbar items to the navbar ER: All the other buttons look the same as they did before you dragged AR: All the other buttons suddenly look all jumbled up. It all looks fine again as soon as you exit customize mode, but it's still pretty jarring.
Whiteboard: [Australis:M?][Australis:P4] → [Australis:P4+]
Attached image Screenshot from Nightly 04-22 Win8 (deleted) —
I can't reproduce this issue on Windows8 running Nightly 4-22. I'll test next on OSX.
I can reproduce this issue on 4-23 Nightly on OSX.
Hardware: x86 → All
Summary: Australis: Moving the bookmarks toolbar items into the navbar causes weird vertical alignment issues with the navbar and some buttons → [OSX] Moving the bookmarks toolbar items into the navbar causes weird vertical alignment issues with the navbar and some buttons
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) (deleted) — — Splinter Review
min-height bites us again...
Attachment #8411232 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8411232 [details] [diff] [review] Patch Review of attachment 8411232 [details] [diff] [review]: ----------------------------------------------------------------- This cuts off the back button (independent of where you put the items): http://imgur.com/CR2qLOx . :-(
Attachment #8411232 - Flags: review?(gijskruitbosch+bugs)
Attached patch Patch v.1 (deleted) — — Splinter Review
That's what I get for writing a patch on what computer, then retyping it on the other computer before uploading. I missed a hyphen in 'customizationtarget', which meant that the rule in the previous version of the patch didn't apply to anything. This is the patch from my Mac, and I tested that it works. Sorry about the double-work.
Attachment #8411232 - Attachment is obsolete: true
Attachment #8413271 - Flags: review?(gijskruitbosch+bugs)
s/on what computer/on one computer/
Comment on attachment 8413271 [details] [diff] [review] Patch v.1 Review of attachment 8413271 [details] [diff] [review]: ----------------------------------------------------------------- D'oh. I should have noticed that... but yes, this works. :-)
Attachment #8413271 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/3b77d1ed52af
status-firefox29: --- → wontfix
status-firefox30: --- → affected
status-firefox31: --- → affected
Whiteboard: [Australis:P4+] → [Australis:P4+][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3b77d1ed52af
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4+][fixed-in-fx-team] → [Australis:P4+]
Target Milestone: --- → Firefox 32
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: