Closed
Bug 923454
Opened 11 years ago
Closed 11 years ago
e.me apps with 3 lines of text get their name cut off
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evyatar, Assigned: evyatar)
References
Details
Attachments
(1 file)
Long names are cut byt a few pixels at the bottom.
STR:
1. Open the "Social" collection
2. Swipe down to the bottom
Result:
"AirBNB Place to Stay" app's name is cut off at the bottom (the wod "Stay".
Expected:
The name should appear perfectly.
|
Assignee | |
Comment 1•11 years ago
|
||
2 main fixes here:
1) When calculating 3 lines of text we ignore the "line height", since there's spacing between each line. Added that.
2) The shadow of the text needed to be added to the final height of the text.
Attachment #813534 -
Flags: review?(ran)
Attachment #813534 -
Flags: review?(crdlc)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 813534 [details]
Patch - redirect to github PR
10x
Attachment #813534 -
Flags: review?(crdlc) → review+
|
||
Comment 3•11 years ago
|
||
3 lines look good. But for some apps, a fourth line peaks.
Search for "maroon more night download"
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 813534 [details]
Patch - redirect to github PR
Fixed and looking good. Great Job!
Attachment #813534 -
Flags: review?(ran) → review+
|
|
||
Comment 5•11 years ago
|
||
Landed in master
https://github.com/mozilla-b2g/gaia/commit/af6f9b86b68464cb3f14ca00788fcf844a0cfb48
Status: ASSIGNED → RESOLVED
blocking-b2g: --- → koi?
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•11 years ago
|
||
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•