This adds support for the Shumway extension (JavaScript/HTML player for SWF) to Metro Firefox -- disabled by default for now, as it is in desktop Firefox.

Comment on attachment 813680 [details] [diff] [review] patch Review of attachment 813680 [details] [diff] [review]: ----------------------------------------------------------------- r+ on metro specific changes. ::: browser/metro/base/content/browser-ui.js @@ +111,5 @@ > PageThumbs.init(); > NewTabUtils.init(); > SettingsCharm.init(); > NavButtonSlider.init(); > + ShumwayUtils.init(); do we need to call this if it's not enabled via prefs?

Touch events simulation is not implemented atm, see https://github.com/mozilla/shumway/issues/767 . So it might be a problem, similar to the bug 859579

(In reply to Jim Mathies [:jimm] from comment #1) > > + ShumwayUtils.init(); > > do we need to call this if it's not enabled via prefs? Yes -- calling it adds a pref observer, so that toggling the pref via about:config will enable the add-on. (In reply to Yury Delendik (:yury) from comment #2) > Touch events simulation is not implemented atm, see > https://github.com/mozilla/shumway/issues/767 . So it might be a problem, > similar to the bug 859579 Yes, I think we should block on good touch support before enabling Shumway by default. But many Windows 8 users have mouse or trackpad instead of (or in addition to) touch, so it will still be easy for most users to test Shumway in Metro.

Comment on attachment 813680 [details] [diff] [review] patch Review of attachment 813680 [details] [diff] [review]: ----------------------------------------------------------------- Reluctant r+ because of poor makeisms. But it's no worse than what's already in this Makefile.in

Backed out along with bug 925796 because one of them caused Metro to crash/hang: https://hg.mozilla.org/integration/fx-team/rev/5ec2fca2c0b0

Pushed to Try to find out whether this still breaks our test automation: https://tbpl.mozilla.org/?tree=Try&rev=c17feef46411

Fixed the failure by adding a missing change to the package manifest: https://tbpl.mozilla.org/?tree=Try&rev=faed35a5ca67 Updated to latest trunk and landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/6370458acfd9

This was merged a while ago but wasn't resolved due to oversight. https://hg.mozilla.org/mozilla-central/rev/6370458acfd9