Closed Bug 923697 Opened 11 years ago Closed 11 years ago

[B2G][Homescreen] There is not a character count limit on app names when users try to remove them

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KTucker, Assigned: crdlc)

References

Details

(Whiteboard: [e.me 1.2 test run])

Attachments

(3 files, 1 obsolete file)

Description: There is not a character cap on collection names. Long collection names are not truncated under the collection icon and will be cutoff. Also, these long collection names cause strange scrolling issues on the "remove screen" and the long collection name will appear when moving around the collection on the homescreen. Repro Steps: 1) Updated Buri Build ID: 20131004040203 2) Long press on an empty part of the homescreen. 3) Tap on "Add Collection". 4) Tap on "Custom". 5) Tap inside the text box and enter in 200 characters. 6) Tap "OK" and then observe the collection name under the icon created. 7) Long press on the created collection and move the icon around the screen. 8) Long press on the collection icon and tap the "X" button. 9) On the "Remove" page, scroll the page to the right and then up and down. Actual: There is not a character count limit on collection names which causes issues. Expected: There is a character count limit on collection names. Environmental Variables Device: Buri v 1.3.0 Mozilla RIL Build ID: 20131004040203 Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8 Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd Platform Version: 27.0a1 RIL Version: 01.02.00.019.056 Notes: Repro frequency: 100% See attached: video clip
Blocks: 1.3-e.me
The video has been posted on Youtube: http://youtu.be/09yiOGCzG5s
(In reply to ktucker from comment #1) > The video has been posted on Youtube: > > http://youtu.be/09yiOGCzG5s The youtube video here isn't viewable. This also needs a screenshot.
Flags: needinfo?(ktucker)
New URL for the Youtube video: http://www.youtube.com/watch?v=pN3Vh9F0a18
Flags: needinfo?(ktucker)
Okay. Sounds like a valid bug, but not a blocking issue.
Component: Gaia::Everything.me → Gaia::Homescreen
Cristian, should this limit be set in Icon.setName?
Flags: needinfo?(crdlc)
Hi all, the name will be truncated in the UI, it makes sense
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Flags: needinfo?(crdlc)
Attached file Patch v1 (deleted) —
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: wrong UI [Testing completed]: yes [Risk to taking this patch] (and alternatives if risky): null [String changes made]:
Attachment #814041 - Flags: review?(ran)
Attachment #814041 - Flags: approval-gaia-v1.2?
Attached image Truncated titles.png (obsolete) (deleted) —
Results of the patch
Attachment #814041 - Attachment description: 12700.html → Patch v1
Cristian, this works well for very long words. But what about a sequence of words? It'll make for a really high title and message in the dialog.
Flags: needinfo?(crdlc)
Attached image Implemented Ran's suggestion (deleted) —
Attachment #814043 - Attachment is obsolete: true
Flags: needinfo?(crdlc)
Comment on attachment 814041 [details] Patch v1 Cool. Works great.
Attachment #814041 - Flags: review?(ran) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Cristian, What's the case for putting this in 1.2? Is this a broken new e.me feature? Not sure why we would need to take it in 1.2
Flags: needinfo?(crdlc)
Hi, Honestly this bug can be reproducible in two scenarios: 1) New feature about adding a new collection (users can write long names) 2) Install a new app from marketplace with a very long name and trying to uninstall it The first case is not reproducible on v1.2 because the new feature won't be available. But the second, being a corner case, could appear on v1.2. I've change the bug title to describe the issue correctly Thanks
Flags: needinfo?(crdlc)
Summary: [B2G][Everything.me] There is not a character count limit on collection names → [B2G][Homescreen] There is not a character count limit on app names when users try to remove them
Comment on attachment 814041 [details] Patch v1 wrong URL is misleading to the user. Hence 1.2+
Attachment #814041 - Flags: approval-gaia-v1.2? → approval-gaia-v1.2+
Comment on attachment 814041 [details] Patch v1 Actually, this isn't needed on 1.2 anymore. The e.me feature set was removed from 1.2, so we don't need this uplifted anymore.
Attachment #814041 - Flags: approval-gaia-v1.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: