Closed Bug 923766 Opened 11 years ago Closed 11 years ago

Single variant applications are not placed in correct position in the homescreen

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+, firefox27 affected, b2g-v1.2 fixed)

VERIFIED FIXED
blocking-b2g koi+
Tracking Status
firefox27 --- affected
b2g-v1.2 --- fixed

People

(Reporter: albert, Assigned: albert)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

(deleted), text/html
yurenju
: review+
macajc
: feedback+
Details
Single variant applications in homescreen always appear at the last position at last page.
Blocks: 893800
blocking-b2g: --- → koi?
Whiteboard: [systemsfe]
Assignee: nobody → acperez
The generated json included in homescreen has a wrong format: {"214-01": [{"screen": 1, "manifest": {"manifestURL": "https://owd.tid.es/store/packages/12a0fcd176beac6141e57389c64e6141.webapp"}, "location": 2}]... It should be: {"214-01": [{"screen": 1, "manifestURL": "https://owd.tid.es/store/packages/12a0fcd176beac6141e57389c64e6141.webapp", "location": 2}]
Attached file Patch (deleted) —
Attachment #813830 - Flags: feedback?(cjc)
Attachment #813830 - Flags: feedback?(cjc) → feedback+
Attachment #813830 - Flags: review?(yurenju.mozilla)
blocking-b2g: koi? → koi+
Attachment #813830 - Flags: review?(yurenju.mozilla) → review+
Master: 5fd0d24152f20ab316596a0b4bd7a7f10b4e3ff7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 813830 [details] Patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Single-variant architecture currently implemented. [User impact] if declined: single variant applications are installed in the last position of the homescreen, not in the configured position. [Testing completed]: yes. [Risk to taking this patch] (and alternatives if risky): low. [String changes made]: none.
Attachment #813830 - Flags: approval-gaia-v1.2?
Comment on attachment 813830 [details] Patch This is already got a koi+, which means it's clear to land on 1.2.
Attachment #813830 - Flags: approval-gaia-v1.2?
Keywords: verifyme
QA Contact: laliaga
Whiteboard: [systemsfe] → [systemsfe],QARegressExclude
Whiteboard: [systemsfe],QARegressExclude → [systemsfe]
Verified Fixed on latest 1.2 and 1.3 on Buri. Newly installed application icons appear on the soonest available slot of the homescreen pages, from the leftmost onward. - Verified Fixed on Buri 1.3 - Gaia 94e3088c56c7348655ae76613defd126426cc722 SourceStamp f80fd27d367f BuildID 20131015004002 Version 26.0a2 - Verified Fixed on Buri 1.2 - Gaia 94e3088c56c7348655ae76613defd126426cc722 SourceStamp f80fd27d367f BuildID 20131015004002 Version 26.0a2
Keywords: verifyme
Whiteboard: [systemsfe] → [systemsfe],QARegressExclude
Whiteboard: [systemsfe],QARegressExclude → [systemsfe],
(In reply to Lucas Aliaga from comment #6) > Verified Fixed on latest 1.2 and 1.3 on Buri. Newly installed application > icons appear on the soonest available slot of the homescreen pages, from the > leftmost onward. > > - Verified Fixed on Buri 1.3 - > Gaia 94e3088c56c7348655ae76613defd126426cc722 > SourceStamp f80fd27d367f > BuildID 20131015004002 > Version 26.0a2 > > - Verified Fixed on Buri 1.2 - > Gaia 94e3088c56c7348655ae76613defd126426cc722 > SourceStamp f80fd27d367f > BuildID 20131015004002 > Version 26.0a2 That's not the right way to verify this bug. You need to setup a customized build with a homescreen grid specified and verify that the apps are placed in the right position.
Keywords: verifyme
Whiteboard: [systemsfe], → [systemsfe]
It can't work on 1.2, still not uplifted.
Uplifted 5fd0d24152f20ab316596a0b4bd7a7f10b4e3ff7 to: v1.2: dd437ca1d08d0f3f627ed0a0cd55f280590845a4
QA Contact: laliaga → jsmith
Basic sanity checks on this on master look fine - marking as verified.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: