Closed
Bug 923776
Opened 11 years ago
Closed 11 years ago
AudioChannelService should not send notifications and/or use callbacks when XPCOM is shutting down.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #813840 -
Flags: review?(ehsan)
|
||
Comment 2•11 years ago
|
||
I see this blocks a blocker - does this need to be koi+?
|
||
Comment 3•11 years ago
|
||
Could this lead to a crash? A la bug 923173?
|
||
Comment 4•11 years ago
|
||
Comment on attachment 813840 [details] [diff] [review]
service.patch
Review of attachment 813840 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/audiochannel/AudioChannelService.h
@@ +178,5 @@
> uint64_t mTimerChildID;
>
> uint64_t mDefChannelChildID;
>
> + bool mDisabled;
Nit: please move the booleans together for better packing.
Attachment #813840 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•