Closed
Bug 924114
Opened 11 years ago
Closed 11 years ago
Migrate homescreen tests to use app objects
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: moz.teodosia, Assigned: ana.nikolaeva)
References
Details
(Whiteboard: [gaia-ui-test])
Attachments
(2 files)
The tests here /tests/functional/homescreen/ can be migrated to use the homescreen app object.
Eg: The method in this tests:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py#L94
can be removed and we can use the one in the homescreen app:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/app.py#L49
Reporter | ||
Updated•11 years ago
|
Whiteboard: [gaia-ui-test]
Assignee | ||
Comment 1•11 years ago
|
||
I can take this.
Comment 2•11 years ago
|
||
I've set you assigned to it Ana.
Ping us if you need any help/advice/etc.
Assignee: nobody → ana.nikolaeva
Assignee | ||
Comment 3•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #816377 -
Flags: review?(zcampbell)
Attachment #816377 -
Flags: review?(moz.teodosia)
Comment 4•11 years ago
|
||
My comments are in the PR
Comment 5•11 years ago
|
||
Comment on attachment 816377 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12806
Great job anah! Just a few comments in the pull request that need to be addressed.
Attachment #816377 -
Flags: review-
Comment 6•11 years ago
|
||
Comment on attachment 816377 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12806
The pull lgtm
Attachment #816377 -
Flags: review+
Updated•11 years ago
|
Attachment #816377 -
Flags: review?(zcampbell)
Attachment #816377 -
Flags: review?(moz.teodosia)
Attachment #816377 -
Flags: review+
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•11 years ago
|
||
Does this also need to be added to the aurora branch?
Reporter | ||
Comment 9•11 years ago
|
||
Yes, we need this on aurora too. I've added bug 932279 for this.
Comment 10•11 years ago
|
||
Pointer to Github pull-request
Comment 11•11 years ago
|
||
Comment on attachment 826436 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13325
Uplifting to v1.2
Attachment #826436 -
Flags: review?(zcampbell)
Attachment #826436 -
Flags: review?(trifandreialin)
Attachment #826436 -
Flags: review?(moz.teodosia)
Attachment #826436 -
Flags: review?(florin.strugariu)
Attachment #826436 -
Flags: review?(andrei.hutusoru)
Updated•11 years ago
|
Comment 14•11 years ago
|
||
Comment on attachment 826436 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13325
This lgtm , runs great!
Attachment #826436 -
Flags: review?(andrei.hutusoru) → review+
Updated•11 years ago
|
Attachment #826436 -
Flags: review?(zcampbell)
Attachment #826436 -
Flags: review?(trifandreialin)
Attachment #826436 -
Flags: review?(moz.teodosia)
Attachment #826436 -
Flags: review?(florin.strugariu)
Attachment #826436 -
Flags: review+
Comment 15•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•