We have a hack-y rule that draws a bottom border on the TabsToolbar, but the border isn't really necessary unless using a lightweight theme.

Makes this rule specific to lightweight themes. Tested with both light and dark themes. Everything seemed hunky-dory there, and fine with the default theme.

Comment on attachment 814186 [details] [diff] [review] Patch v1 Review of attachment 814186 [details] [diff] [review]: ----------------------------------------------------------------- This is the right idea, but breaks when drawInTitlebar = false, as there's no bottom border for the navbar. Also, even with drawInTitlebar = true, there's a subtle change in the contrast with the (unselected) tab separators (according to my eyes and the digital color meter thing in OS X when comparing two screenshots of current trunk and trunk + 924181 + 924182). I think we should land this when you fix the drawInTitlebar case, but we should file a P5 followup to check with Stephen and get new images for those separators if necessary.

(In reply to :Gijs Kruitbosch from comment #2) > there's no bottom border for the navbar. I meant the tabbar, of course. :-|

Ah, good eyes! Ok, I'll fix the drawInTitlebar = false case.

Handles not drawing in the titlebar

Comment on attachment 814202 [details] [diff] [review] Patch v1.1 How does this look to you?

Comment on attachment 814202 [details] [diff] [review] Patch v1.1 Review of attachment 814202 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Mike Conley (:mconley) from comment #6) > Comment on attachment 814202 [details] [diff] [review] > Patch v1.1 > > How does this look to you? It makes me sad we don't have any way to tell whether tabsintitlebar is true from the tabstrip itself. Yucky descendant selectors. But otherwise, yeah, that WFM, and works with drawInTitlebar turned off. Thanks!

This was landed last night: https://hg.mozilla.org/projects/ux/rev/646cc8771af8