Closed
Bug 924248
Opened 11 years ago
Closed 11 years ago
Make nsIDocument.h go on a diet
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
text/html
|
Details |
Attachment #814251 -
Flags: review?(jst)
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 814251 [details] [diff] [review]
Patch (v1)
The cached encoder bits might be perf-sensitive. Make sure to measure!
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 814251 [details] [diff] [review]
> Patch (v1)
>
> The cached encoder bits might be perf-sensitive. Make sure to measure!
That's only used in Element::GetMarkup. Would a micro-benchmark test case which measures innerHTML performance in a loop be enough here?
|
|
||
Comment 4•11 years ago
|
||
Yes, it would. Esp for the case when an element has no kids.
|
|
Assignee | |
Comment 5•11 years ago
|
||
This patch does not move the needle on this small testcase.
|
||
Updated•11 years ago
|
Attachment #814251 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•