Closed Bug 924286 Opened 11 years ago Closed 11 years ago

Handle AudioChunk::mVolume (from GainNode) in BiquadFilterNodeEngine

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27
Tracking Flags:
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

handle non-unit mVolume
(deleted), patch
ehsan.akhgari
: review+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review
No description provided.
Attached patch handle non-unit mVolume (deleted) — — Splinter Review
Attachment #814651 - Flags: review?(ehsan)
Will include testcase in bug 924288.
Flags: in-testsuite?
Comment on attachment 814651 [details] [diff] [review] handle non-unit mVolume Review of attachment 814651 [details] [diff] [review]: ----------------------------------------------------------------- Sorry that I forgot about this. I think I forgot to handle mVolume in about every single engine that I implemented. And I did audit them all at some point but perhaps it was before BiquadFilterNode.
Attachment #814651 - Flags: review?(ehsan) → review+
:) I'm bit surprised it took us so long to notice. I've checked all the nodes that use the blink subdir, and Bug 924290 is the only remaining.
Er, I mean bug 924289.
(In reply to comment #5) > Er, I mean bug 924289. \o/
Oh, sorry. Good news: blink/DynamicsCompressor.cpp already handles that (since bug 864613).
https://hg.mozilla.org/mozilla-central/rev/d53c32505943
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Test landed in bug 924288 https://hg.mozilla.org/integration/mozilla-inbound/rev/d8fe38e7b4f7
Flags: in-testsuite? → in-testsuite+
Comment on attachment 814651 [details] [diff] [review] handle non-unit mVolume [Approval Request Comment] Bug caused by (feature/regressing bug #): Web Audio BiquadFilterNode bug 865246 User impact if declined: There are some situations (single non-null input BiquadFilterNode) where an author's gain control will be completely ineffective. For example, attempts to silence a stream will fail. Testing completed (on m-c, etc.): on m-c, aurora; in testsuite Risk to taking this patch (and alternatives if risky): small patch, small influence, low risk String or IDL/UUID changes made by this patch: none
Attachment #814651 - Flags: approval-mozilla-beta?
Attachment #814651 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: