Closed
Bug 92479
Opened 23 years ago
Closed 23 years ago
nsPersistentProperties reads 1 byte at a time.
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
WONTFIX
mozilla1.0
People
(Reporter: dougt, Assigned: darin.moz)
References
Details
(Keywords: perf)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
nsPersistentProperties reads one char at a time from the input stream. This
should be change to read and process a block at a time.
Reporter | ||
Updated•23 years ago
|
Summary: nsPersistentProperties read 1 byte at a time. → nsPersistentProperties reads 1 byte at a time.
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
ack. bad patch. I am reallocating when I don't have too...
Reporter | ||
Comment 3•23 years ago
|
||
Comment 5•23 years ago
|
||
Wow, so...how many times do we buffer this data now? (I'd have thought the whole
point of nsIUnicharInputStream would've been to buffer the data.) Would it be
better to do the buffering there?
I notice that |ConverterInputStream| (in nsUnicharInputStream.cpp) has an
|nsIUnicharBuffer| member: is this not working right?
Reporter | ||
Comment 6•23 years ago
|
||
I should have marked this bug dependent on
http://bugzilla.mozilla.org/show_bug.cgi?id=92477.
ignore for now... I need to get results.
Depends on: 92477
Reporter | ||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.4
Reporter | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Reporter | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.5 → mozilla1.0
Comment 7•23 years ago
|
||
Doug ? Seems wrong to make this mozilla1.0 This looks like it can give a sizable
perf improvement.
Reporter | ||
Comment 8•23 years ago
|
||
It was marked m1.0 because 93055 was. I see that Darin moved it up.
Darin, do you want to see if you can fix up these two callers (92477 and this)
Reporter | ||
Comment 9•23 years ago
|
||
to darin. This should be changed along with the changes to support partial
reads
Assignee: dougt → darin
Assignee | ||
Comment 10•23 years ago
|
||
is this really a big performance problem? NS_NewConvertStream returns a input
stream that has a buffer. therefore, reading one byte at a time is not really
all that costly.
i also don't believe that this change would be blocked by bug 93055.
resolving WONTFIX unless someone can show that this will actually help. IMO
this is only bloat.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•