Closed
Bug 924882
Opened 11 years ago
Closed 11 years ago
test_setup_active_sync needs extra wait for setup screen
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: bsilverberg)
References
Details
Attachments
(2 files)
Assignee | ||
Comment 1•11 years ago
|
||
I'm not seeing any new setup screen. The test usually passes on my device but I did get a failure or two. I think we just need to add a wait here. I am working on a PR for that.
Assignee: nobody → bob.silverberg
Assignee | ||
Updated•11 years ago
|
Summary: test_setup_active_sync needs extra work for new setup screen → test_setup_active_sync needs extra wait for setup screen
Assignee | ||
Comment 2•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #815046 -
Flags: review?(zcampbell)
Attachment #815046 -
Flags: review?(moz.teodosia)
Attachment #815046 -
Flags: review?(andrei.hutusoru)
Attachment #815046 -
Flags: review?(alin.trif)
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Bob Silverberg [:bsilverberg] from comment #1)
> I'm not seeing any new setup screen. The test usually passes on my device
> but I did get a failure or two. I think we just need to add a wait here. I
> am working on a PR for that.
Probably right - I didn't run the test locally I just tried to interpret the CI test run results!
Comment 4•11 years ago
|
||
Comment on attachment 815046 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12762
Although the test was passing for me before this wait, this wait does not affect in any bad way the test.
tested it locally -> pass!
Attachment #815046 -
Flags: review?(alin.trif) → review+
Comment 5•11 years ago
|
||
Comment on attachment 815046 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12762
LGTM
Attachment #815046 -
Flags: review?(andrei.hutusoru) → review+
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 815046 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12762
Runs spiffingly on Hamachi!
Attachment #815046 -
Flags: review?(zcampbell)
Attachment #815046 -
Flags: review?(moz.teodosia)
Attachment #815046 -
Flags: review+
Reporter | ||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 826355 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13318
Uplifting to v1.2
Attachment #826355 -
Flags: review?(zcampbell)
Attachment #826355 -
Flags: review?(trifandreialin)
Attachment #826355 -
Flags: review?(moz.teodosia)
Attachment #826355 -
Flags: review?(florin.strugariu)
Attachment #826355 -
Flags: review?(andrei.hutusoru)
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•11 years ago
|
Attachment #826355 -
Flags: review?(zcampbell)
Attachment #826355 -
Flags: review?(trifandreialin)
Attachment #826355 -
Flags: review?(moz.teodosia)
Attachment #826355 -
Flags: review?(florin.strugariu)
Attachment #826355 -
Flags: review?(andrei.hutusoru)
Attachment #826355 -
Flags: review+
Comment 10•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•