Julien Wajsberg [:julienw] Reporter
	Description • 11 years ago

Implement Bug 914454 for 1.2 and master. 

If we don't do it in 1.2 we'll regress since bug 914454 is in 1.1.

	Preeti Raghunath(:Preeti)
	Comment 1 • 11 years ago

Next steps? Is this a l10n issue?

	Julien Wajsberg [:julienw] Reporter
	Comment 2 • 11 years ago

Next step is to do what we did in Bug 914454 in master and 1.2 in the keyboard app. We might need to do some adjustment in the Sms app too (especially the name of the inputmode as the one used in Bug 914454 is not the best one imo :) ).

This is a blocker for the Greek market according to DT.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 3 • 11 years ago

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Next step is to do what we did in Bug 914454 in master and 1.2 in the
> keyboard app. We might need to do some adjustment in the Sms app too
> (especially the name of the inputmode as the one used in Bug 914454 is not
> the best one imo :) ).
> 
> This is a blocker for the Greek market according to DT.

I am confused. Won't what landed to v1.2 and master in bug 914454 work?

	Julien Wajsberg [:julienw] Reporter
	Comment 4 • 11 years ago

Tim, the keyboard part from bug 914454 did not land in master and 1.2. (or am I wrong here ?)

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 5 • 11 years ago

Right, so we need 

https://github.com/mozilla-b2g/gaia/commit/735d9f7871d4352989c54ce7143c8a0163f3418f

on master.

This is really confusing....

	Julien Wajsberg [:julienw] Reporter
	Comment 6 • 11 years ago

Right, with imho some changes that I outlined in bug 914454 comment 107 (using mutation events, and changing the inputmode name).

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 7 • 11 years ago

Sorry about causing the confusion.
This is partially because the keyboard part of Bug 914454 is a quick fix for v1.1 only and at that time we think we will have a thorough solution for v1.2 (and of course a different patch).

But since we also comes to an end for v1.2, maybe we need to migrate the same solution there to v1.2 and master first. Will try to make that happen soon.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 8 • 11 years ago

(In reply to Julien Wajsberg [:julienw] from comment #6)
> Right, with imho some changes that I outlined in bug 914454 comment 107
> (using mutation events, and changing the inputmode name).

I think we are safe to "downlift" the Greek SMS keyboard to v1.2/master but adding the mutation observer to detect the inputmode change. Please file another bug for that.

Rudy is this *the* bug you are working on today? If not tell me exactly what to do so people could steal this bug.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 9 • 11 years ago

I'm going to send a patch for this today.
Thank you.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 10 • 11 years ago

?

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 11 • 11 years ago

Hi David,

This is basically Bug 914454 and 927321, but for master and v1.2
Please help take a look at this patch.

Thank you.

--
Tim,

Sorry for being late to provide the patch.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 12 • 11 years ago

Comment on attachment 822722 [details]
github pull request 13110

Julien,

Please help to review the SMS app part about the renaming of inputmode from "-moz-sms-7bit" to "-moz-sms".

Thanks.

	Julien Wajsberg [:julienw] Reporter
	Comment 13 • 11 years ago

> but adding the mutation observer to detect the inputmode change.
> Please file another bug for that.

Do you mean I should file another bug for adding the mutation observer ?

	Julien Wajsberg [:julienw] Reporter
	Comment 14 • 11 years ago

Note that without the mutation observer, one case is not working as expected, when the user switches from SMS to MMS and vice versa.

	Julien Wajsberg [:julienw] Reporter
	Comment 15 • 11 years ago

Comment on attachment 822722 [details]
github pull request 13110

r=me for the SMS part, but i'd really want to have the mutation observer implemented here.

	David Flanagan [:djf]
	Comment 16 • 11 years ago

Comment on attachment 822722 [details]
github pull request 13110

I still wish we could just have an SMS layout available on the greek keyboard and just alow the user to select that layout when the need it.

But I guess this approach is what we have to do for now.

See my comments on github, but basically, this looks fine to me.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 17 • 11 years ago

Gaia master,
https://github.com/mozilla-b2g/gaia/commit/50c5c530ffef00cb7b24d00e23cbed80210105d2

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 18 • 11 years ago

Uplifted to v1.2,
https://github.com/mozilla-b2g/gaia/commit/183d4ea2c875024a6302b0f2a241cbe56e61a3b7

	Julien Wajsberg [:julienw] Reporter
	Comment 19 • 11 years ago

Rudy, would you please file a bug for the mutation event change ? I think you're the best one to describe what's needed :)

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 20 • 11 years ago

Not a dependency of this bug.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 21 • 11 years ago

Julien, thanks for the reminding.
Bug 933637 filed to track this.