Closed
Bug 925005
Opened 11 years ago
Closed 11 years ago
Inclusion of moztest breaks mach b2g desktop mochi tests
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: qdot, Assigned: qdot)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
New moztest module was added for marionette (bug 879900) but not added to mach search paths.
Attachment #814982 -
Flags: review?(gps)
Comment 1•11 years ago
|
||
We should really be pulling these from testing/mozbase/packages.txt or similar
Comment 3•11 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #1)
> We should really be pulling these from testing/mozbase/packages.txt or
> similar
+1 ; we even have the option (which I believe is currently enforced, maybe?) of unrolling the deps correctly if it makes a difference (which it shouldn't here, fwiw).
Comment 4•11 years ago
|
||
Comment on attachment 814982 [details] [diff] [review]
Patch 1 (v1) - Add moztest module path to mach search paths
Review of attachment 814982 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, the sys.path foo in mach_bootstrap.py is currently a giant hack. Ironing out virtualenv integration issues with mach is on my long todo list and sadly isn't near the top.
We should schedule a meeting to talk about how to do this right. For now, easy r+.
Attachment #814982 -
Flags: review?(gps) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•