Closed Bug 925284 Opened 11 years ago Closed 4 years ago

Arrow panels are visually inconsistent across the UI and look awkward

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: fb+mozdev, Unassigned)

References

Details

(Keywords: meta, Whiteboard: [Australis:P5])

Attachments

(5 files)

Attached image Mac OS X 10.8 identity and menu panels (deleted) —
I have the following (visual) issues with doorhangers in Australis (as tested on Mac and XP), in descending order of severity: 1. Inconsistent styling: The identity (and similar) and menu doorhanger (and similar) differ visually. Most prominent is the lighter border and maybe shadow around the menu panel which makes the up arrow look off (on Mac); on XP, the menu panel has no shadow while the identity panel has. 2. Arrow too "fat": Especially for the menu panel on Mac (at least without addressing issue #1), the arrow button looks too much in-your-face. Additionally, due to the size and location (relative to the panel) of the arrow, when using the full width of the device display (which is probably the most used size on <14" screens), the panel has to move into the window, which looks awkward, too. Having a smaller (and maybe repositioned) arrow will fix this at least partially. 3. Differing alignment: As seen in the screenshots, the panels have a different offset. That stems from the different types of buttons they originate from, however it leaves a weird feeling while using Australis (at least for me on Mac). If using arrows of different size (see issue #2) for different panels (trade-off with consistency here!), the alignment issue can be fixed (at least for some platforms). Otherwise the panel position (relative to the button it originates from) has to be changed.
Attached image XP indentity and menu panels (deleted) —
(Could also fit into autralis-navbar, please change the dependency if you think this fits better!)
Blocks: australis
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [Australis:P5][Australis:M?]
Note that the two items in the screenshots are arrow panels, not doorhanger notifications (which use arrow panels).
Summary: Doorhangers are visually inconsistent across the UI and look awkward → Arrow panels are visually inconsistent across the UI and look awkward
Ah, I always wondered about the difference … thanks!
Bug 930064 covers issue #1 from comment 0.
Depends on: 930064
Bug 940797 aims to improve platform consistency.
Depends on: 940797
Depends on: 878065
Depends on: 767321
Blocks: 767321
No longer depends on: 767321
Depends on: 968595
Whiteboard: [Australis:P5][Australis:M?] → [Australis:P5]
Florian, is this still an issue?
Flags: needinfo?(fb+mozdev)
This bug could be repurposed to cover for example the panel footers unification (plugins activation, identity panel, etc.)
(In reply to Philipp Sackl [:phlsa] (Firefox UX) please use needinfo from comment #7) > Florian, is this still an issue? Hi there! I'm not Florian but I've tested issue 3 (different alignment) and created a new image with several panels open on Nightly 42.0a1 (2015-07-29). I've used a MacBook Pro with Retina and OS X Yosemite 10.10.4. Here the measured offsets: - page info 80dppx / 40px - bookmarks 76dppx / 38px - downloads 78dppx / 39px - dev tools 80dppx / 40px - main menu 80dppx / 40px The numbers look like very small differences, but for me it's still visible without a huge effort, even in normal use.
Still issue in Photon, or is fixed now?
Attached image firefox_popups_with_lines.png (deleted) —
Attached image firefox_popups_without_lines.png (deleted) —
I don't know which outstanding changes are currently in the making, but it's still an issue in the current Nightly (2017-08-11). I've created a new image to visualize the current state. There are five different y axis positions, I think there should be at most two (one for the address bar and one for all other icons). The overflow menu panel has no border radius while all other panels have a border radius. (I preferred the edgy style for Photon, but that´s another thing ;) .) The site identity panel is a little bit translucent all others are not. Beside that all panels seem to have the same styling.
Flags: needinfo?(fb+mozdev)
Should be blocking for Photon, not Australis then. ;)
I guess that's the right one ;)
(In reply to Alexander Ploner from comment #13) > The overflow menu panel has no border radius while all other panels have a > border radius. That's bug 1374315. > The site identity panel is a little bit translucent all others are not. That's supposed to be fixed in bug 1374749.
No longer blocks: photon-visual
Component: Toolbars and Customization → Theme
Depends on: 1374315, 1374749
Keywords: meta
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: