Closed
Bug 925514
Opened 11 years ago
Closed 11 years ago
#nav-bar noise texture tweaks
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [Australis:M9][Australis:P1])
Attachments
(2 files)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
The noise in the tabs has device pixel resolution in the @2x versions, too, so making this change makes the noise match the tabs better. It may also slightly improve performance because we don't need to scale anymore.
Attachment #815593 -
Flags: review?(gijskruitbosch+bugs)
|
Assignee | |
Comment 1•11 years ago
|
||
This makes the noise image no longer overlap the tabbar using background-position and repeat-x.
Attachment #815594 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•11 years ago
|
Blocks: australis-tabs-perf
|
||
Comment 2•11 years ago
|
||
Comment on attachment 815594 [details] [diff] [review]
no-noise-in-overlap
r=me, I tried using a border and it gets more tricky. This should Just Work, in theory...
Attachment #815594 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 815593 [details] [diff] [review]
hidpi-navbarnoise
r=me, although I'd like buy-in from mconley
Attachment #815593 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 4•11 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3)
> Comment on attachment 815593 [details] [diff] [review]
> hidpi-navbarnoise
>
> r=me, although I'd like buy-in from mconley
... especially when https://tbpl.mozilla.org/?tree=Try&rev=6f8bd327bba5 finishes (yay, data!)
|
|
||
Comment 5•11 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Comment on attachment 815593 [details] [diff] [review]
> > hidpi-navbarnoise
> >
> > r=me, although I'd like buy-in from mconley
>
> ... especially when https://tbpl.mozilla.org/?tree=Try&rev=6f8bd327bba5
> finishes (yay, data!)
http://compare-talos.mattn.ca/?oldRevs=e6cd734560ac&newRev=6f8bd327bba5&server=graphs.mozilla.org&submit=true
says substantial 10.6/10.7 wins, minimal impact on 10.8. I wonder why. Anyway, I figured we should just land this:
https://hg.mozilla.org/projects/ux/rev/1283fdd7c0e0
https://hg.mozilla.org/projects/ux/rev/8ff50813bf91
Whiteboard: [Australis:M9][Australis:P1][fixed-in-ux]
|
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8ff50813bf91
https://hg.mozilla.org/mozilla-central/rev/1283fdd7c0e0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P1][fixed-in-ux] → [Australis:M9][Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•