Closed Bug 925804 Opened 11 years ago Closed 11 years ago

Marketplace web activity to open a target app details page from cold launch launches marketplace, but not the target app details page

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jsmith, Assigned: cvan)

References

Details

Attachments

(2 files)

Seen while doing marketplace integration into e.me testing. When you select a marketplace app found in e.me search results, the marketplace app would open, but not the target app details page. Per the discussion on bug 910316, the e.me team is claiming this is a bug on the marketplace side on how they are handling web activity requests from a cold launch. Still digging into why, but making sure I get a bug on file for this.
Blocks: 925806
Has this been tested with the latest, updated version of the Marketplace package?
Also, can you provide code that demonstrates the failure?
(In reply to Matt Basta [:basta] from comment #1) > Has this been tested with the latest, updated version of the Marketplace > package? It was tested with what is currently in Gaia. https://github.com/mozilla-b2g/gaia/tree/master/external-apps/marketplace.firefox.com (In reply to Matt Basta [:basta] from comment #2) > Also, can you provide code that demonstrates the failure? e.me team probably could help you with that. Ran - Can you provide the relevant e.me code for when a user selects a marketplace suggestion in e.me search results?
Flags: needinfo?(ran)
As I mentioned in another bug, I have not updated the Marketplace .zip in gaia. I will do that. I wanted QA to verify the webactivities before upstreaming it to gaia.
Attachment #816062 - Flags: review?(fabrice)
Attachment #816062 - Flags: feedback?(jsmith)
Chris is updating the marketplace app in Gaia - so moving this over to Gaia.
Component: General → Gaia
Product: Marketplace → Boot2Gecko
Version: Avenir → unspecified
Comment on attachment 816062 [details] https://github.com/mozilla-b2g/gaia/pull/12799 etags and zip file look okay. Can't check activities because I don't have the e.me code in question that triggers the activity over to marketplace. We need to land this update anyways, so we can do that post landing in the bug this blocks.
Attachment #816062 - Flags: feedback?(jsmith) → feedback+
Attached file application.zip (deleted) —
Comment on attachment 816062 [details] https://github.com/mozilla-b2g/gaia/pull/12799 Clearing review since we discussed some issues with cvan on irc.
Attachment #816062 - Flags: review?(fabrice)
Flags: needinfo?(ran)
Fabrice: I've updated https://github.com/cvan/gaia/blob/4c1661d/external-apps/marketplace.firefox.com/application.zip to fix this use case: 1) Get the latest Marketplace update or (via desktop b2g) install Marketplace packaged app: https://marketplace.firefox.com/app/marketplace/?region=worldwide 2) Launch in Browser: http://jsbin.com/USEHoGA/1 3) Marketplace is launched and we are navigated to Little Alchemy … 4) Close Browser 5) In Marketplace app go back to homepage 6) Launch in Browser: http://jsbin.com/USEHoGA/1 7) Marketplace is focussed and we are navigated to Little Alchemy
what's the next step on this bug?
Flags: needinfo?(cvan)
Attachment #816062 - Flags: review?(fabrice)
Fabrice, when you get a minute, could please review this and (if all looks good) merge it in. http://jsbin.com/EhEGEpe/2 is the test case. See comment 11, where I've outlined the steps to verify that I've addressed the issue you found per comment 10. Many thanks!
Flags: needinfo?(cvan)
Assignee: nobody → cvan
Attachment #816062 - Flags: review?(fabrice) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Christopher, I still cannot get the jsbin tests to work. The Marketplace app doesn't open :-/ Unagi, Gecko 27.0a1, Latest Gaia (ff127af) Does it work on your device?
Flags: needinfo?(cvan)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This has already landed & should not be reopened unless the patch is backed out.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
File a followup if there's followup work needed here.
jsmith: does the marketplace app details page open as expected?
Flags: needinfo?(jsmith)
(In reply to Caitlin Galimidi from comment #18) > jsmith: does the marketplace app details page open as expected? If it's not working as expected, file a followup bug for the issue you are seeing.
Flags: needinfo?(jsmith)
(In reply to Ran Ben Aharon (Everything.me) from comment #15) > Christopher, I still cannot get the jsbin tests to work. The Marketplace app > doesn't open :-/ > > Unagi, Gecko 27.0a1, Latest Gaia (ff127af) > > Does it work on your device? Does http://jsbin.com/EhEGEpe/2 launch the Marketplace for you? Please file a follow up bug and point me to your jsbin tests. Thanks!
Flags: needinfo?(cvan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: