Closed
Bug 925817
Opened 11 years ago
Closed 11 years ago
GenerationalGC: Refactor inside nursery check to avoid repetition
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
If we move the definition of IsInsideNursery() into HeapAPI.h, we can get rid of the repeated expansion of this.
Attachment #815944 -
Flags: review?(terrence)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 815944 [details] [diff] [review]
refactor-inside-nursery
Review of attachment 815944 [details] [diff] [review]:
-----------------------------------------------------------------
I'm a bit leery of exposing this to API since we don't actually want anyone using it -- we will need to change it's semantics at some point -- but the change is more than nice enough to merit that minor risk. r=me
Attachment #815944 -
Flags: review?(terrence) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•