Closed Bug 925850 Opened 11 years ago Closed 11 years ago

Modify the test_dialer_make_call assertion to handle long phone numbers

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
Other
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zcampbell, Unassigned)

References

Details

(Whiteboard: [mentor=zac][lang=py])

Attachments

(2 files)

added assert for long phone numbers
(deleted), text/x-github-pull-request
zcampbell
: review+
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13323
(deleted), text/html
Bebe
: review+
Details
When we rnu test_dialer_make_call in the UK we get this failure message because phone numbers are longer: AssertionError: u'+447911111111' != u'+4479111111\u2026' - +447911111111 ? ^^ + +4479111111\u2026 Whereas in MV it is fine with a shorter phone number. We need to modify this assertion in some way to handle short and long numbers. I would be OK with just checking the first 11 characters but if you have a more creative way then feel free to propose that too!
I will take a look at this, thanks!
Assignee: nobody → andrei.hutusoru
Good task for contributor!
Assignee: andrei.hutusoru → nobody
Whiteboard: [mentor=zac][lang=py]
Attached file added assert for long phone numbers (deleted) —
pointer to pull request https://github.com/mozilla-b2g/gaia/pull/12881
Attachment #817688 - Flags: review?(zcampbell)
Attachment #817688 - Flags: review?(andrei.hutusoru)
Comment on attachment 817688 [details] added assert for long phone numbers Comments in the PR
Attachment #817688 - Flags: review?(zcampbell) → review-
Comment on attachment 817688 [details] added assert for long phone numbers modified version is r+!
Attachment #817688 - Flags: review?(andrei.hutusoru)
Attachment #817688 - Flags: review-
Attachment #817688 - Flags: review+
Merged https://github.com/mozilla-b2g/gaia/commit/616e87af0133496620aea89f21ca5d37acedf466
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 826428 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13323 Uplifting to v1.2
Attachment #826428 - Flags: review?(zcampbell)
Attachment #826428 - Flags: review?(trifandreialin)
Attachment #826428 - Flags: review?(moz.teodosia)
Attachment #826428 - Flags: review?(florin.strugariu)
Attachment #826428 - Flags: review?(andrei.hutusoru)
Blocks: 934130
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 826428 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13323 LGTM
Attachment #826428 - Flags: review?(zcampbell)
Attachment #826428 - Flags: review?(trifandreialin)
Attachment #826428 - Flags: review?(moz.teodosia)
Attachment #826428 - Flags: review?(florin.strugariu)
Attachment #826428 - Flags: review?(andrei.hutusoru)
Attachment #826428 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/331379c33a6ed80a542b616db205680fe93790a0
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: