Description: The user cannot see a contact that they receive from another user exporting via Bluetooth. Repro Steps: 1) Update Buri to Build ID: 20131011004001 2) Connect to another device that has contacts via Bluetooth. 3) On the other device, launch the Contacts app. 4) Select Settings then Export Contacts. 5) Select Bluetooth, then a contact to export, then the Export button. 6) Select the test device on the Bluetooth page and wait for the test device to accept the transfer. 7) On the test device tap the transfer notification that appears then accept the transfer. 8) Once the transfer completes, tap the notification and observe the page that appears. Actual: The contact list opens but the imported contact is not present on the contact list. Expected: The contact list opens and the imported contact is present on the contact list. Environmental Variables Device: Buri 1.2 mozilla RIL Build ID: 20131011004001 Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/c8e97fd5b94d Gaia: 79abf09f2b5b6440f43cb5ae44ef6c85c0437e8d Platform Version: 26.0a2 Notes: Repro frequency: 100% Link to failed test case: https://moztrap.mozilla.org/manage/cases/?filter-id=9814 See attached logcat logs The contact is present on the SD card, but the user has to import from the SD card in order to see it, which the user may not know is required.

Sounds like this is a broken 1.2 feature.

triage: koi+, regression

Discovered that a change on the way we load contacts overlay was making the call fail, and the whole importing process was aborted (without warning the user). Opened bug 932358 for tracking this (possible) case

Comment on attachment 824086 [details] Link to PR - https://github.com/mozilla-b2g/gaia/pull/13189 Redirecting to a contacts peer.

(In reply to Etienne Segonzac (:etienne) from comment #4) > Comment on attachment 824086 [details] > Link to PR - https://github.com/mozilla-b2g/gaia/pull/13189 > > Redirecting to a contacts peer. Ooops...maybe it would be a good idea to update the suggested reviewers list? I chose you just because you appear in there with the lowest number of reviews pending :p

Comment on attachment 824086 [details] Link to PR - https://github.com/mozilla-b2g/gaia/pull/13189 Hmm, I think there is still a race here. The Contacts.utility() lazy load could conceivably complete after the processTextFromFile() runs. Its very low probability, but possible I suppose. This would be bad because that code also calls utils.overlay. I think it would be safer to run the entire importFromVcard() function as the callback to Contacts.utility() to ensure that the overlay is loaded before starting the load. I'd like to look at this again, so r- for right now. This looks close, though. Thanks!

Comment on attachment 824086 [details] Link to PR - https://github.com/mozilla-b2g/gaia/pull/13189 ok, code fixed, you were right about the race condition. Tests are green also

Comment on attachment 824086 [details] Link to PR - https://github.com/mozilla-b2g/gaia/pull/13189 Looks good! Just a few nits on GH. r=me with green travis. Thanks!

Comments addressed, green tests \o/ merged on master c15445e4c5ee863a5c9ac377553d290ab428f314 bug affects v1.2, so asking for approval

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: unable to import contacts from vcard [Testing completed]: [Risk to taking this patch] (and alternatives if risky): low, it takes care of loading resources before calling functions [String changes made]:

Uplifted c15445e4c5ee863a5c9ac377553d290ab428f314 to: v1.2: 4ee8fedea97154c226cd7a02abcf0d1934027865

Verified that user is able to receive contacts from Bluetooth and they show up in the Contacts list. Device: Buri v 1.2 Com RIL BuildID: 20131111004004 Gaia: 670b2c8329bca6f142939185be71274166d82bb8 Gecko: 1ac147e4e2f0 Version: 26.0 Firmware Version: 20131104