Closed
Bug 926798
Opened 11 years ago
Closed 10 years ago
IME support for e10s
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: m_kato, Assigned: m_kato)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
When turning on e10s, IME on content doesn't works on Windows nightly build. Of course, it works on chrome (ex. address bar) GetDesiredIMEState() always returns IMEState::DISABLE on e10s, so nsIMEStateManager::GetNewIMEState turns off IME state. nsIMEStateManaber should query content process for IME state.
Assignee | ||
Comment 1•11 years ago
|
||
Also, before IME_START_COMPOSITION, NS_QUERY_SELECTED_TEXT is called. So when calling it, GetIMETabParent is still null.
Assignee | ||
Comment 2•11 years ago
|
||
Assignee: nobody → m_kato
Assignee | ||
Comment 3•11 years ago
|
||
IPDL generates default constructor for IPC. So we should remove MOZ_CRASH for it.
Assignee | ||
Comment 4•11 years ago
|
||
TODO: IME requires NS_QUERY_TEXT_RECT and NS_QUERY_CARET_RECT for content process (TabParent)
Assignee | ||
Updated•11 years ago
|
Attachment #818172 -
Attachment is obsolete: true
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 818171 [details] [diff] [review] always use CROSS_IME Always use MOZ_CROSS_PROCESS_IME.
Attachment #818171 -
Attachment description: Part 1. always use CROSS_IME → always use CROSS_IME
Attachment #818171 -
Flags: review?(cpeterson)
Assignee | ||
Comment 6•11 years ago
|
||
After this, user can input text via IME. But candidate window may be wrong position. Bug 935821 will fix this issue.
Comment 7•11 years ago
|
||
Comment on attachment 818171 [details] [diff] [review] always use CROSS_IME Bill, can you please Makoto's IME changes?
Attachment #818171 -
Flags: review?(cpeterson) → review?(wmccloskey)
Comment on attachment 818171 [details] [diff] [review] always use CROSS_IME Review of attachment 818171 [details] [diff] [review]: ----------------------------------------------------------------- Thanks very much for working on this! It looks like bug 835591 disabled this stuff because it makes b2g startup slower. So I think it would be better to put this at the top of the file instead: #ifndef MOZ_B2G #define MOZ_CROSS_PROCESS_IME #endif Also, I think :roc would be a good reviewer for this code in the future.
Attachment #818171 -
Flags: review?(wmccloskey)
Assignee | ||
Comment 9•11 years ago
|
||
MOZ_CROSS_PROCESS_IME is required for e10s IME But, comment #8 by billm, defined MOZ_CROSS_PROCESS_IME is performance problem on B2G, so MOZ_CROSS_PROCESS_IME is only defined on non-B2G build
Attachment #818171 -
Attachment is obsolete: true
Attachment #8339200 -
Flags: review?(roc)
Assignee | ||
Updated•11 years ago
|
Attachment #8339200 -
Attachment is patch: true
Attachment #8339200 -
Flags: review?(roc) → review+
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1168eb4503
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c1168eb4503
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•