Closed
Bug 927592
Opened 11 years ago
Closed 11 years ago
modal dialog handling doesn't work if you start a session early
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)
RESOLVED
FIXED
mozilla27
People
(Reporter: mdas, Assigned: mdas)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
using the --restart option when running gaiatest exposed this issue in https://bugzilla.mozilla.org/show_bug.cgi?id=779284#c69.
Attachment #818055 -
Flags: review?(jgriffin)
|
Assignee | |
Comment 1•11 years ago
|
||
This patch has been tested against a device using the --restart option when running https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_delete_image.py repeatedly, and it works as expected
|
||
Comment 2•11 years ago
|
||
Comment on attachment 818055 [details] [diff] [review]
wait for document ready to attach listener, and only do so if we're in B2G
Review of attachment 818055 [details] [diff] [review]:
-----------------------------------------------------------------
This code makes the mozbrowsershowmodalprompt B2G-specific. r+ if that's what we want.
Attachment #818055 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yeah, we don't need this code in normal Firefox builds, it should just be added for B2G builds.
landed in m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1ab0fcde02
|
|
Assignee | |
Comment 4•11 years ago
|
||
this will have to be uplifted to aurora when it lands in m-c
status-firefox26:
--- → affected
|
||
Comment 5•11 years ago
|
||
Assignee: nobody → mdas
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
|
Assignee | |
Comment 6•11 years ago
|
||
This is blocking testing in aurora.
Whiteboard: [checkin-needed-aurora]
|
|
Assignee | |
Comment 7•11 years ago
|
||
pushed to aurora;
https://hg.mozilla.org/releases/mozilla-aurora/rev/c23fabebe5b1
Whiteboard: [checkin-needed-aurora]
|
|
Assignee | |
Updated•11 years ago
|
|
||
Updated•11 years ago
|
status-b2g-v1.2:
--- → fixed
status-firefox27:
--- → fixed
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•