Closed
Bug 927635
Opened 11 years ago
Closed 7 years ago
Copy official and unofficial branding files in multilocale.py
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: zbraniecki, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Branding files aren't correctly picked up
Comment 1•11 years ago
|
||
This bug results in errors like the following ones /home/stas/moz/b2g/gaia/shared/locales/branding/unofficial/branding.ar.properties could not be found. /home/stas/moz/b2g/gaia/shared/locales/branding/unofficial/branding.ar.properties could not be found.
Comment 2•11 years ago
|
||
Can you be more precise on what this bug is about? I'm asking because we're not exposing official branding to l10n, but we do expose unofficial.
Comment 3•11 years ago
|
||
The key lines in the patch are: + # copy official branding from en-US, not from source + copy_official_branding(target_dirname, filename, locale) + # localization files can only modify unofficial branding, + # amend the path accordingly + target_dirname = os.path.join(target_dirname, 'unofficial') Currently, we read all English files (say, settings.properties and branding.properties) and then overwrite the English translations in the gL10nData dict with another language, but this another language's branding files are not in shared/. So everything works as expected for official branding, because we do want en-US there, but it doesn't work for unofficial. Also, if we ever switch the way we compose the translations dictionary (e.g. in L20n each locale is stored separately), we'll run into 404 errors.
Comment 4•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•