Brian R. Bondy [:bbondy] Reporter
	Description • 11 years ago

Until we have support for private browsing in Metro, we should not give the user the option to switch to Metro if they are in private browsing mode on Desktop.

	Brian R. Bondy [:bbondy] Reporter
	Comment 1 • 11 years ago

p=2

	(no longer active)
	Comment 2 • 11 years ago

(In reply to Brian R. Bondy [:bbondy] from comment #0)
> Until we have support for private browsing in Metro, we should not give the
> user the option to switch to Metro if they are in private browsing mode on
> Desktop.

That doesn't make sense to me.  There is no "private browsing mode" any more, all you have is private windows.

I think this is WONTFIX.

	Brian R. Bondy [:bbondy] Reporter
	Comment 3 • 11 years ago

I don't think this is WONTFIX.
I don't think we want to present the user with the option to relaunch in Metro if they are in a private browser window.  Because they may think that they are relaunching in Metro mode while maintaining their private status. This was originally a concern brought up by Asa by the way.

	Marina Samuel [:emtwo] Assignee
	Comment 4 • 11 years ago

If we use the patch from bug 934032 comment 16, this patch should do the trick for disallowing switching to metro when private browsing

	Marina Samuel [:emtwo] Assignee
	Comment 5 • 11 years ago

By the way, the patch from comment 4 makes the 'metro mode' button not visible for windows in private mode so these windows cannot be switched over to metro, but normal windows can.

	(no longer active)
	Comment 6 • 11 years ago

Marina demoed what this bug is about to me in person.  I was confused when reading comment 0, but what she has implemented in this bug makes sense to me now!

	Brian R. Bondy [:bbondy] Reporter
	Comment 7 • 11 years ago

Great, thanks for keeping an eye out! :D

	Marina Samuel [:emtwo] Assignee
	Comment 8 • 11 years ago

This one is for oak/mc

	Brian R. Bondy [:bbondy] Reporter
	Comment 9 • 11 years ago

Comment on attachment 831708 [details] [diff] [review]
v1: Disallow switch to metro when private browsing

Review of attachment 831708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-appmenu.inc
@@ +5,5 @@
>  
>  <menupopup id="appmenu-popup"
>             onpopupshowing="if (event.target == this) {
>                               updateEditUIVisibility();
> +                             CheckForPrivateMode();

nit: Please call this updateMetroVisibility()

	Brian R. Bondy [:bbondy] Reporter
	Comment 10 • 11 years ago

updateSwitchToMetroVisibility

	Marina Samuel [:emtwo] Assignee
	Comment 11 • 11 years ago

Addressed comment

	Brian R. Bondy [:bbondy] Reporter
	Comment 12 • 11 years ago

Comment on attachment 8333885 [details] [diff] [review]
v2: Disallow switch to metro when private browsing for Holly

Review of attachment 8333885 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to carry forward r+s btw. Thanks :D

	Brian R. Bondy [:bbondy] Reporter
	Comment 13 • 11 years ago

Landed on oak here:
https://hg.mozilla.org/projects/oak/rev/e15485cd77ad

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.

	Brian R. Bondy [:bbondy] Reporter
	Comment 14 • 11 years ago

https://hg.mozilla.org/integration/fx-team/rev/074a7f87397c

	Carsten Book [:Tomcat]
	Comment 15 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/074a7f87397c

	Brian R. Bondy [:bbondy] Reporter
	Comment 16 • 11 years ago

https://hg.mozilla.org/projects/holly/rev/7f73c5b97f2c

	Manuela Muntean [Away]
	Comment 17 • 11 years ago

Verified as fixed for iteration #19, with latest Nightly from 2013-12-01 on Win 8 64-bit.

While in a private window, the "Metro Mode" button doesn't appear in the Customize panel, therefore Metro can't be launched in this situation.