+++ This bug was initially created as a clone of Bug #789217 +++ Failed to building b2g-desktop when compiling ipc/keystore/KeyStore.cpp: ipc/keystore/KeyStore.cpp:40:30: error: 'unlink' was not declared in this scope ipc/keystore/KeyStore.h:37:31: error: 'NAME_MAX' was not declared in this scope

Since B2G WiFi is only available on Gonk, I suggest guard ipc/keystore with MOZ_WIDGET_GONK instead of MOZ_B2G_RIL. Actually, we're going to allow building B2G without RIL (see bug 920551), which follows MOZ_B2G_RIL will not be defined in that case, and that will certainly break current keystore code.

Nominate for koi+ for we have to above reason.

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2) > Nominate for koi+ for above reason. Sorry, press 'save' button too early.

Change build rule per but 789217 comment 52. unixsocket ipc is required for keystore, but BT might not always be enabled under condition |MOZ_WIDGET_TOOKIT == 'gonk'|. So the new rule is always enable unixsocket and keystore ipc under gonk. Otherwise, enable unixsocket based on BT flag.

Run try to make sure WIP patch can be built on all platform : https://tbpl.mozilla.org/?tree=Try&rev=4daa6bdae203

Comment on attachment 818898 [details] [diff] [review] WIP : Change build condition. Review of attachment 818898 [details] [diff] [review]: ----------------------------------------------------------------- SystemWorkerManager.cpp:34:34: fatal error: mozilla/ipc/KeyStore.h: No such file or directory 14:15.56 make[5]: *** [SystemWorkerManager.o] Error 1 14:15.56 make[4]: *** [dom/system/gonk/compile] Error 2 14:15.56 make[4]: *** Waiting for unfinished jobs.... I must add b2g-desktop is officially built without MOZ_B2G_RIL, so the patch here works fine. But since the original problem is bug 789217 fails b2g-desktop build with MOZ_B2G_RIL enabled, so this patch doesn't really solve the core issue. https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Using_the_B2G_desktop_client

Fix build error mentioned in comment 6.

Comment on attachment 818951 [details] [diff] [review] WIP. Change keystore ipc depedency. There's still build error.

1. build keystore and unixsocket while using gonk. 2. build unixsocket when bluetooth support is enabled but not using gonk.

Make sure everything is fine : https://tbpl.mozilla.org/?tree=Try&rev=7cb7b46a51cc

Comment on attachment 819522 [details] [diff] [review] Change keystore ipc depedency. Review of attachment 819522 [details] [diff] [review]: ----------------------------------------------------------------- This patch isn't related to Bluetooth implementaion very much. khuey and vicamo are much more qualified than me to review this. :)

Comment on attachment 819522 [details] [diff] [review] Change keystore ipc depedency. Review of attachment 819522 [details] [diff] [review]: ----------------------------------------------------------------- Bug 920551 is going to remove all MOZ_WIDGET_GONK labels in dom/system/gonk because we'll only compile stuff inside when we're really building b2g with Gonk. Unless the review prefers another way, the lines added in this patch will soon be removed again. So I'd like to wait for the result there and see if we really need this. Thank you, Chuck :)

Look like we can mark it as duplicate of bug 920551 now. Thank you!