Closed
Bug 928281
Opened 11 years ago
Closed 11 years ago
[Gaia] Set keyboard iframe attribute "remote=true" for keyboard OOP
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
(Whiteboard: [3rd-party-keyboard])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #816874 +++
This is a Gaia change to modify "remote=true" for the keyboard frame when loading 3rd-party keyboard app.
** For triage **
This is for keyboard OOP, so nominate it as koi+.
Comment 1•11 years ago
|
||
(In reply to Rudy Lu [:rudyl] from comment #0)
> +++ This bug was initially created as a clone of Bug #816874 +++
>
> This is a Gaia change to modify "remote=true" for the keyboard frame when
> loading 3rd-party keyboard app.
>
> ** For triage **
> This is for keyboard OOP, so nominate it as koi+.
Plus it based on the comments
blocking-b2g: koi? → koi+
Updated•11 years ago
|
Target Milestone: --- → 1.2 C4(Nov8)
Updated•11 years ago
|
Assignee: nobody → gchen
Assignee | ||
Comment 2•11 years ago
|
||
We already have a patch to activate this, but are waiting for Bug 847763 to land.
Assignee: gchen → rlu
Whiteboard: [3rd-party-keyboard]
Assignee | ||
Comment 3•11 years ago
|
||
As an offline discussion, we want to add a setting entry to enable keyboard OOP first so that it would be easy to test Gecko patch.
This setting entry will need to be removed before shipping.
--
Tim, could you help review this?
Thanks.
Attachment #822774 -
Flags: review?(timdream)
Comment 4•11 years ago
|
||
Comment on attachment 822774 [details]
pull request 13115
Thanks!
Attachment #822774 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Landed to Gaia master:
https://github.com/mozilla-b2g/gaia/commit/9c6586d85d4340600ace0aa69f5741c5f3f67970
--
Tim, thanks for the quick review.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•11 years ago
|
||
Backed out with Bug 912010 with this commit,
90fbd75eccd3408ca04907fd80b72275771b3b30
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•11 years ago
|
||
relanded in 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 8•11 years ago
|
||
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•11 years ago
|
||
Relanded with this commit,
https://github.com/mozilla-b2g/gaia/commit/5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
(In reply to Rudy Lu [:rudyl] from comment #9)
> Relanded with this commit,
> https://github.com/mozilla-b2g/gaia/commit/
> 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
Correction: not reland, commit in comment 8 was not pushed to gaia master.
Comment 11•11 years ago
|
||
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1.2
git cherry-pick -x 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(rlu)
Comment 13•11 years ago
|
||
v1.2 reverted: 9d335a436d494c3703e98e195c6d94da4be9a15d
https://tbpl-dev.allizom.org/?rev=fc1043ab2d67&tree=Mozilla-B2g26-v1.2
Updated•11 years ago
|
Flags: needinfo?(rlu)
Comment 14•11 years ago
|
||
v1.2 reland: e717aec947571f5daf923c040a82f9f0719bb526
Let's see if we could isolate the issue.
Comment 15•11 years ago
|
||
Sorry, wrong bug. Please ignore comment 14.
Comment 16•11 years ago
|
||
v1.2 reland: 9e4c9a71c93620c6529a904ee16b745d570e4a9e
Comment 17•11 years ago
|
||
v1.2 revert #2: 9e4c9a71c93620c6529a904ee16b745d570e4a9e
Comment 18•11 years ago
|
||
Correction,
v1.2 revert #2: 9bdd41c3dea84905ad93d02dfa36f92757ea1ada
Comment 19•11 years ago
|
||
See bug 933718. It seems that this bug is not the cause of TBPL fail. We should re-land the bug once the tree is open.
Comment 20•11 years ago
|
||
v1.2 reland #2: 2e5dc6b9600bf2bc2ff3fc359120e2883ef50e38
You need to log in
before you can comment on or make changes to this bug.
Description
•