Closed Bug 928292 Opened 11 years ago Closed 11 years ago

[DSDS][Gaia] System should handle multiple sim card locks

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, firefox28 fixed, b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 6 - 12/6
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox28 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: arthurcc, Assigned: alive)

References

Details

(Whiteboard: [L2][Blocked by devices])

Attachments

(1 file)

DSDS SIM PIN
(deleted), text/x-github-pull-request
timdream
: review+
arthurcc
: feedback+
Details
- When users unlock the device, dialogs that allow users to unlock multiple sim cards should be displayed. - When users launch apps that need a locked sim card, an unlocking dialog should also be displayed.
Hey Sandip, if both the SIMs in DSDS are PIN locked wouldn't we need support for this bug to unlock both SIMs? If yes, then this should be 1.3+
Flags: needinfo?(skamat)
blocking-b2g: 1.3? → 1.3+
Arthur, do we know when we could finish this bug? Thanks!
Flags: needinfo?(arthur.chen)
Flags: needinfo?(arthur.chen)
Target Milestone: --- → 1.3 Sprint 5 - 11/22
(In reply to Anshul from comment #1) > Hey Sandip, if both the SIMs in DSDS are PIN locked wouldn't we need support > for this bug to unlock both SIMs? If yes, then this should be 1.3+ Correct. It is for 1.3.
Flags: needinfo?(skamat)
Whiteboard: [L2]
Target Milestone: 1.3 Sprint 5 - 11/22 → 1.3 Sprint 6 - 12/6
Plan to land it in the 2nd week of sprint 6.
Whiteboard: [L2] → [L2][Blocked by devices]
The comment #4 is still valid.
Steal
Assignee: arthur.chen → alive
Depends on: 946125
What's the status now?
Have a working patch, writing tests now.
Attached file DSDS SIM PIN (deleted) —
Rock DSDS!
Attachment #8343041 - Flags: review?(timdream)
Attachment #8343041 - Flags: feedback?(arthur.chen)
Attachment #8343041 - Flags: feedback?(arthur.chen) → feedback+
Comment on attachment 8343041 [details] DSDS SIM PIN Thank you for taking the initiative and helping out!
Attachment #8343041 - Flags: review?(timdream) → review+
We really need to know when the bug can be landed, because DSDS is a committed feature. Can you help to provide the ETA? Thank you.
https://github.com/mozilla-b2g/gaia/commit/dfd6a873b5cd57943f5988c202b03e17262c52cd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Request the approval of uplifting this patch to the v1.3 branch. This blocks one of the major DSDS features and also partner's tests. We have unit tests for the modified part (sim_pin_dialog) and also the tests for the newly added module. This feature is also covered by moztraps as it is part of the v1.3 user story.
Flags: needinfo?(fabrice)
Alive, I believe Bug 946603 will also block this bug, am I correct?
Flags: needinfo?(alive)
Yes for: the retryCount=-1 always is a regression.
Flags: needinfo?(alive)
(In reply to Alive Kuo [:alive][NEEDINFO] from comment #15) > Request the approval of uplifting this patch to the v1.3 branch. > > This blocks one of the major DSDS features and also partner's tests. We have > unit tests for the modified part (sim_pin_dialog) and also the tests for the > newly > added module. This feature is also covered by moztraps as it is part of the > v1.3 user story. Ok, feel free to merge.
Flags: needinfo?(fabrice)
What's the ETA on uplifting this to 1.3?
Blocks: 948852
Need followup 928852 to be 1.3+ as well in order not to break 1.3
c0aa854489c102fad8ea7deac68f4e36fbe39e2a v1.3
status-firefox28: affected → fixed
(In reply to Alive Kuo [:alive][NEEDINFO] from comment #20) > Need followup 928852 to be 1.3+ as well in order not to break 1.3 I saw bug 928852 is duplicate to bug 928847, which is RESOLVED INVALID. What's the plan we can take to get it landed in 1.3?
Flags: needinfo?(alive)
I put the wrong bug number :( It's bug 948852 and already 1.3+ THX!
Flags: needinfo?(alive)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: