Closed
Bug 928306
Opened 11 years ago
Closed 11 years ago
[Flatfish][System] Make system dialogs not fill full screen
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
Attachments
(4 files)
alert
Make system dialogs not fill full screen, have modal dialog instead
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gasolin
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
change based on gaia-local modifications https://github.com/gaia-local/gaia/pull/76/files
Attachment #820131 -
Flags: review?(alive)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 820131 [details]
pull request redirect to github
CSS only and Tablet only change r=me
Attachment #820131 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/0b66bad10344044dbf130a8f793d2d94b5d4d8b1
thanks!
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 820131 [details]
pull request redirect to github
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment] CSS only and Tablet only change
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: tablet only
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]:
Attachment #820131 -
Flags: approval-gaia-v1.2?
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 820131 [details]
pull request redirect to github
Draw back the v1.2 approval since there's still some dialogs need to be updated.
Its better to have them all in a release version, which we could not commit it will happens in v1.2.
It might be better to let vendor decide if they want cherry-pick this to v1.2
Attachment #820131 -
Flags: approval-gaia-v1.2?
You need to log in
before you can comment on or make changes to this bug.
Description
•