Closed
Bug 928870
Opened 11 years ago
Closed 11 years ago
Basic tests for Android WebRTC UI
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: gcp, Assigned: gcp)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
This code is very similar to the Doorhanger tests, so it could perhaps go in those tests and shave a few seconds off each test run. On the other hand we're not interested in actually checking the Doorhanger code, we really want to know if WebRTC is starting up and identifying devices correctly, then transmitting that to the C++/JavaScript code.
This works on pandas but not on tegras, i.e. verified manually that the UI will pop up on panda but not tegra. tegras will skip the test because they are missing the relevant Android API (level) anyway.
I'm assuming here that the reason WebRTC doesn't work on the pandas is that they just don't have the hardware, rather than that WebRTC is broken on them :P
Assignee | ||
Updated•11 years ago
|
Attachment #819661 -
Attachment is patch: true
Attachment #819661 -
Flags: review?(gbrown)
Assignee | ||
Updated•11 years ago
|
Blocks: android-webrtc
Comment 1•11 years ago
|
||
Comment on attachment 819661 [details] [diff] [review]
Patch 1. Basic WebRTC UI Tests
Review of attachment 819661 [details] [diff] [review]:
-----------------------------------------------------------------
I would prefer that this was added to testDoorHanger, to save time (time to launch xpcshell, launch the browser, wait for Gecko:Ready), but it's okay as it is.
::: mobile/android/base/tests/testGetUserMedia.java.in
@@ +10,5 @@
> +import java.lang.reflect.Method;
> +
> +import org.json.JSONArray;
> +import org.json.JSONException;
> +import org.json.JSONObject;
There's a bunch of unused imports here.
Attachment #819661 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Assignee: nobody → gpascutto
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•