Closed
Bug 928890
Opened 11 years ago
Closed 11 years ago
contacts facebook import broken by webidl change
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
(Whiteboard: [c= p=1 s= u=])
Attachments
(1 file)
E/GeckoConsole( 2808): [JavaScript Error: "TypeError: 'additionalName' member of ContactProperties can't be converted to a sequence." {file: "app://communications.gaiamobile.org/contacts/js/fb/fb_contact.js" line: 135}]
Assignee | ||
Updated•11 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Whiteboard: [c= p= s= u=]
Assignee | ||
Comment 1•11 years ago
|
||
Hmm, fb_contact.js wants to set the mozContacts.updated field, but that is read-only in webidl world.
Assignee | ||
Comment 2•11 years ago
|
||
This pull request makes contact properties array where appropriate. It also no longer uses mozContact for the prototype of the merged object.
This was causing problems when trying to set the updated and published fields. Using null for the prototype seems to work in my tests, but we need to carefully review this.
Jose, what do you think?
Assignee | ||
Comment 3•11 years ago
|
||
Also, this depends on the fix in bug 928875 to pass the mozContact object correctly to mozContacts.save().
Depends on: 928875
Comment 4•11 years ago
|
||
Hi Ben,
It is apparently ok but I would like to do additional testing with FB linking. As now the Contacts App is unstable that will be done tomorrow once I can create a contact :)
Tomorrow the review will be finished!
thanks!
Comment 5•11 years ago
|
||
Comment on attachment 819689 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/12974
basic testing performed and working
thanks, Ben
Attachment #819689 -
Flags: review?(jmcf) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Thanks Jose! Merged:
https://github.com/mozilla-b2g/gaia/commit/e37ae7e657de942c66fccaf9e6a5f953880cb575
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Whiteboard: [c= p= s= u=] → [c= p=1 s= u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•